github-mirror/discourse
github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-04-01 19:55:40 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

Fix specs, handle_exception calls

Browse Source
This commit is contained in:
riking 2014-06-30 15:16:16 -07:00
parent eb14983dfa
commit 07cedb7946
2 changed files with 5 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
app/jobs/scheduled/poll_mailbox.rb
View File

@ -47,7 +47,7 @@ module Jobs
client_message = RejectionMailer.send_rejection(message.from, message.body, message.to, message_template) client_message = RejectionMailer.send_rejection(message.from, message.body, message.to, message_template)
Email::Sender.new(client_message, message_template).send Email::Sender.new(client_message, message_template).send
else else
Discourse.handle_exception(e, { context: "incoming email", mail: mail_string }) Discourse.handle_exception(e, { context: { code: "unknown error for incoming email", mail: mail_string} })
end end
ensure ensure
mail.delete mail.delete
@ -70,7 +70,7 @@ module Jobs
pop.finish pop.finish
end end
rescue Net::POPAuthenticationError => e rescue Net::POPAuthenticationError => e
Discourse.handle_exception(e, { context: "signing in for incoming email" }) Discourse.handle_exception(e, { context: { code: "signing in for incoming email" } })
end end
end end

5
spec/jobs/poll_mailbox_spec.rb
View File

@ -28,12 +28,13 @@ describe Jobs::PollMailbox do
describe ".poll_pop3s" do describe ".poll_pop3s" do
it "informs admins on pop authentication error" do it "logs an error on pop authentication error" do
error = Net::POPAuthenticationError.new error = Net::POPAuthenticationError.new
data = { limit_once_per: 1.hour, message_params: { error: error }} data = { limit_once_per: 1.hour, message_params: { error: error }}
Net::POP3.expects(:start).raises(error) Net::POP3.expects(:start).raises(error)
GroupMessage.expects(:create).with("admins", :email_error_notification, data)
Discourse.expects(:handle_exception)
poller.poll_pop3s poller.poll_pop3s
end end