github-mirror/discourse
github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-03-19 20:55:41 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

FIX: Handle missing git repo details in plugin list (#24539)

Browse Source 
Followup to e37fb3042d6f56a27a01614e57bc7029f472b0c9,
in some cases we cannot get git information for the
plugin folder (e.g. permission issues), so we need
to only try and get information about it if
commit_hash is present.
This commit is contained in:
Martin Brennan 2023-11-24 12:08:10 +10:00 committed by GitHub
parent d667c22171
commit 09c446c1ae
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 8 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
lib/plugin/instance.rb
View File

@ -519,8 +519,9 @@ class Plugin::Instance
end
def discourse_owned?
return false if commit_hash.blank?
parsed_commit_url = UrlHelper.relaxed_parse(self.commit_url)
return false if !parsed_commit_url
return false if parsed_commit_url.blank?
github_org = parsed_commit_url.path.split("/")[1]
(github_org == "discourse" || github_org == "discourse-org") &&
parsed_commit_url.host == "github.com"

6
spec/lib/plugin/instance_spec.rb
View File

@ -42,6 +42,12 @@ RSpec.describe Plugin::Instance do
plugin.git_repo.stubs(:url).returns("http://github.com/someguy/someguy-plugin")
expect(plugin.discourse_owned?).to eq(false)
end
it "returns false if the commit_url is missing because of git command issues" do
plugin = Plugin::Instance.find_all("#{Rails.root}/spec/fixtures/plugins")[3]
plugin.git_repo.stubs(:latest_local_commit).returns(nil)
expect(plugin.discourse_owned?).to eq(false)
end
end
end