From 0caeadd9b1cc78c6aefe424741752231f27d84ba Mon Sep 17 00:00:00 2001
From: Martin Brennan <martin@discourse.org>
Date: Mon, 13 Jan 2025 13:03:13 +1000
Subject: [PATCH] FEATURE: Add IP Lookup to review queue (#30688)

Moves the theme component
https://github.com/discourse/discourse-review-ip-lookup into core, this
allows looking
up a user's IP directly from the review queue and seeing if
there are other users with the same IP on the forum
---
 .../admin/addon/components/ip-lookup.gjs      | 36 ++++++++++++-------
 .../app/components/reviewable-item.hbs        |  7 ++++
 .../app/components/reviewable-item.js         |  9 +++++
 3 files changed, 39 insertions(+), 13 deletions(-)

diff --git a/app/assets/javascripts/admin/addon/components/ip-lookup.gjs b/app/assets/javascripts/admin/addon/components/ip-lookup.gjs
index eb5690e1923..05a88e92021 100644
--- a/app/assets/javascripts/admin/addon/components/ip-lookup.gjs
+++ b/app/assets/javascripts/admin/addon/components/ip-lookup.gjs
@@ -16,6 +16,8 @@ import { i18n } from "discourse-i18n";
 import AdminUser from "admin/models/admin-user";
 import DMenu from "float-kit/components/d-menu";
 
+const MAX_ACCOUNTS_TO_DELETE = 50;
+
 export default class IpLookup extends Component {
   @service dialog;
   @service site;
@@ -26,13 +28,13 @@ export default class IpLookup extends Component {
   @tracked loading = false;
   @tracked otherAccountsLoading = false;
   @tracked totalOthersWithSameIP;
+  @tracked ipToLookup = this.args.ip;
 
   get otherAccountsToDelete() {
     const otherAccountsLength = this.otherAccounts?.length || 0;
     const totalOthers = this.totalOthersWithSameIP || 0;
-    // can only delete up to 50 accounts at a time
-    const total = Math.min(50, totalOthers);
-    const visible = Math.min(50, otherAccountsLength);
+    const total = Math.min(MAX_ACCOUNTS_TO_DELETE, totalOthers);
+    const visible = Math.min(MAX_ACCOUNTS_TO_DELETE, otherAccountsLength);
     return Math.max(visible, total);
   }
 
@@ -40,18 +42,27 @@ export default class IpLookup extends Component {
   async lookup() {
     this.loading = true;
     try {
-      if (!this.location && this.args.ip) {
-        const loc = await ajax("/admin/users/ip-info", {
-          data: { ip: this.args.ip },
-        });
-        this.location = loc;
+      if (this.args.ip === "adminLookup") {
+        try {
+          const userInfo = await AdminUser.find(this.args.userId);
+          this.ipToLookup = userInfo.ip_address;
+        } catch (err) {
+          popupAjaxError(err);
+          return;
+        }
       }
 
-      if (!this.otherAccounts && this.args.ip) {
+      if (!this.location && this.ipToLookup) {
+        this.location = await ajax("/admin/users/ip-info", {
+          data: { ip: this.ipToLookup },
+        });
+      }
+
+      if (!this.otherAccounts && this.ipToLookup) {
         this.otherAccountsLoading = true;
 
         const data = {
-          ip: this.args.ip,
+          ip: this.ipToLookup,
           exclude: this.args.userId,
           order: "trust_level DESC",
         };
@@ -75,7 +86,7 @@ export default class IpLookup extends Component {
   @action
   async copy() {
     const { location } = this;
-    let text = `IP: ${this.args.ip}`;
+    let text = `IP: ${this.ipToLookup}`;
 
     if (location) {
       if (location.hostname) {
@@ -111,7 +122,6 @@ export default class IpLookup extends Component {
     this.dialog.yesNoConfirm({
       message: i18n("ip_lookup.confirm_delete_other_accounts"),
       didConfirm: async () => {
-        // reset state
         this.otherAccounts = null;
         this.otherAccountsLoading = true;
         this.totalOthersWithSameIP = null;
@@ -120,7 +130,7 @@ export default class IpLookup extends Component {
           await ajax("/admin/users/delete-others-with-same-ip.json", {
             type: "DELETE",
             data: {
-              ip: this.args.ip,
+              ip: this.ipToLookup,
               exclude: this.args.userId,
               order: "trust_level DESC",
             },
diff --git a/app/assets/javascripts/discourse/app/components/reviewable-item.hbs b/app/assets/javascripts/discourse/app/components/reviewable-item.hbs
index 09b8d4c3ae5..9e4f2113717 100644
--- a/app/assets/javascripts/discourse/app/components/reviewable-item.hbs
+++ b/app/assets/javascripts/discourse/app/components/reviewable-item.hbs
@@ -135,6 +135,13 @@
       {{/if}}
     {{/if}}
 
+    {{#if this.showIpLookup}}
+      <IpLookup
+        @ip="adminLookup"
+        @userId={{this.reviewable.target_created_by.id}}
+      />
+    {{/if}}
+
     <PluginOutlet
       @name="reviewable-item-actions"
       @connectorTagName="div"
diff --git a/app/assets/javascripts/discourse/app/components/reviewable-item.js b/app/assets/javascripts/discourse/app/components/reviewable-item.js
index 3f4d7f9f50e..d8da717e3ac 100644
--- a/app/assets/javascripts/discourse/app/components/reviewable-item.js
+++ b/app/assets/javascripts/discourse/app/components/reviewable-item.js
@@ -188,6 +188,15 @@ export default class ReviewableItem extends Component {
     return updatedCategoryId || categoryId;
   }
 
+  @discourseComputed("reviewable.type", "reviewable.target_created_by")
+  showIpLookup(reviewableType) {
+    return (
+      reviewableType !== "ReviewableUser" &&
+      this.currentUser.staff &&
+      this.reviewable.target_created_by
+    );
+  }
+
   @bind
   _performConfirmed(performableAction, additionalData = {}) {
     let reviewable = this.reviewable;