github-mirror/discourse
github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-03-22 06:25:39 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

FIX: Use find_by_id method to prevent record not found exception

Browse Source
This commit is contained in:
Vinoth Kannan 2018-12-15 03:19:45 +05:30
parent 430083019d
commit 0d3c1cde90
2 changed files with 7 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
lib/cooked_post_processor.rb
View File

@ -513,7 +513,7 @@ class CookedPostProcessor
end end
upload_id = downloaded_images[src] upload_id = downloaded_images[src]
upload = Upload.find(upload_id) if upload_id upload = Upload.find_by_id(upload_id) if upload_id
img["src"] = upload.url if upload.present? img["src"] = upload.url if upload.present?
# make sure we grab dimensions for oneboxed images # make sure we grab dimensions for oneboxed images

6
spec/components/cooked_post_processor_spec.rb
View File

@ -778,6 +778,12 @@ describe CookedPostProcessor do
cpp.post_process_oneboxes cpp.post_process_oneboxes
expect(cpp.doc.to_s).to eq("<p><img class=\"onebox\" src=\"#{upload.url}\" width=\"\" height=\"\"></p>") expect(cpp.doc.to_s).to eq("<p><img class=\"onebox\" src=\"#{upload.url}\" width=\"\" height=\"\"></p>")
upload.destroy
cpp = CookedPostProcessor.new(post, invalidate_oneboxes: true)
cpp.post_process_oneboxes
expect(cpp.doc.to_s).to eq("<p><img class=\"onebox\" src=\"#{image_url}\" width=\"\" height=\"\"></p>")
end end
it "replaces large image placeholder" do it "replaces large image placeholder" do