github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-01-18 20:03:15 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

DEV: enforces table-groups linting rule (#8903)

Browse Source
This commit is contained in:
Joffrey JAFFEUX 2020-02-10 08:14:26 +01:00 committed by GitHub
parent 99ad2e408a
commit 0d9b99582d
18 changed files with 614 additions and 589 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
.template-lintrc.js
View File

@ -4,6 +4,7 @@ module.exports = {
rules: {
"self-closing-void-elements": true,
"table-groups": true,
"style-concatenation": true
}
};

4
app/assets/javascripts/admin/templates/email-bounced.hbs
View File

@ -8,7 +8,7 @@
<th>{{i18n 'admin.email.email_type'}}</th>
</tr>
</thead>
<tbody>
<tr class="filters">
<td>{{i18n 'admin.email.logs.filters.title'}}</td>
<td>{{text-field value=filter.user placeholderKey="admin.email.logs.filters.user_placeholder"}}</td>
@ -39,7 +39,7 @@
<tr><td colspan="4">{{i18n 'admin.email.logs.none'}}</td></tr>
{{/unless}}
{{/each}}
</tbody>
</table>
{{/load-more}}

2
app/assets/javascripts/admin/templates/email-index.hbs
View File

@ -1,4 +1,5 @@
<table class="table">
<tbody>
<tr>
<th>{{i18n 'admin.email.delivery_method'}}</th>
<td>{{delivery_method}}</td>
@ -10,6 +11,7 @@
<td>{{s.value}}</td>
</tr>
{{/each}}
</tbody>
</table>
<form>

3
app/assets/javascripts/admin/templates/email-received.hbs
View File

@ -9,6 +9,7 @@
</tr>
</thead>
<tbody>
<tr class="filters">
<td>{{i18n 'admin.email.logs.filters.title'}}</td>
<td>{{text-field value=filter.from placeholderKey="admin.email.incoming_emails.filters.from_placeholder"}}</td>
@ -50,7 +51,7 @@
{{else}}
<tr><td colspan="4">{{i18n 'admin.email.incoming_emails.none'}}</td></tr>
{{/each}}
</tbody>
</table>
{{/load-more}}

3
app/assets/javascripts/admin/templates/email-rejected.hbs
View File

@ -10,6 +10,7 @@
</tr>
</thead>
<tbody>
<tr class="filters">
<td>{{i18n 'admin.email.logs.filters.title'}}</td>
<td>{{text-field value=filter.from placeholderKey="admin.email.incoming_emails.filters.from_placeholder"}}</td>
@ -53,7 +54,7 @@
{{else}}
<tr><td colspan="5">{{i18n 'admin.email.incoming_emails.none'}}</td></tr>
{{/each}}
</tbody>
</table>
{{/load-more}}

4
app/assets/javascripts/admin/templates/email-sent.hbs
View File

@ -9,7 +9,7 @@
<th>{{i18n 'admin.email.reply_key'}}</th>
</tr>
</thead>
<tbody>
<tr class="filters">
<td>{{i18n 'admin.email.logs.filters.title'}}</td>
<td>{{text-field value=filter.user placeholderKey="admin.email.logs.filters.user_placeholder"}}</td>
@ -48,7 +48,7 @@
<tr><td colspan="5">{{i18n 'admin.email.logs.none'}}</td></tr>
{{/unless}}
{{/each}}
</tbody>
</table>
{{/load-more}}

4
app/assets/javascripts/admin/templates/email-skipped.hbs
View File

@ -9,7 +9,7 @@
<th>{{i18n 'admin.email.skipped_reason'}}</th>
</tr>
</thead>
<tbody>
<tr class="filters">
<td>{{i18n 'admin.email.logs.filters.title'}}</td>
<td>{{text-field value=filter.user placeholderKey="admin.email.logs.filters.user_placeholder"}}</td>
@ -44,7 +44,7 @@
<tr><td colspan="5">{{i18n 'admin.email.logs.none'}}</td></tr>
{{/unless}}
{{/each}}
</tbody>
</table>
{{/load-more}}

2
app/assets/javascripts/admin/templates/permalinks.hbs
View File

@ -21,6 +21,7 @@
<th class="col heading external_url">{{i18n 'admin.permalink.external_url'}}</th>
<th class="col heading actions"></th>
</thead>
<tbody>
{{#each model as |pl|}}
<tr class="admin-list-item">
<td class="col first url">{{pl.url}}</td>
@ -49,6 +50,7 @@
</td>
</tr>
{{/each}}
</tbody>
</table>
{{else}}
{{i18n 'search.no_results'}}

3
app/assets/javascripts/admin/templates/user-badges.hbs
View File

@ -36,6 +36,7 @@
{{/if}}
<table id='user-badges'>
<tbody>
<tr>
<th>{{i18n 'admin.badges.badge'}}</th>
<th>{{i18n 'admin.badges.granted_by'}}</th>
@ -43,7 +44,6 @@
<th>{{i18n 'admin.badges.granted_at'}}</th>
<th></th>
</tr>
{{#each groupedBadges as |userBadge|}}
<tr>
<td>{{user-badge badge=userBadge.badge count=userBadge.count}}</td>
@ -79,6 +79,7 @@
</td>
</tr>
{{/each}}
</tbody>
</table>
</div>
{{/conditional-loading-spinner}}

2
app/assets/javascripts/discourse/templates/about.hbs
View File

@ -68,6 +68,7 @@
<h3>{{d-icon "far-chart-bar"}} {{i18n 'about.stats'}}</h3>
<table class='table'>
<tbody>
<tr>
<th>&nbsp;</th>
<th>{{i18n 'about.stat.last_7_days'}}</th>
@ -104,6 +105,7 @@
<td>{{number model.stats.likes_30_days}}</td>
<td>{{number model.stats.like_count}}</td>
</tr>
</tbody>
</table>
</section>

2
app/assets/javascripts/discourse/templates/components/categories-only.hbs
View File

@ -21,6 +21,7 @@
{{/if}}
{{#if c.isGrandParent}}
<table class="category-list subcategories-with-subcategories">
<tbody>
{{#each c.subcategories as |subcategory|}}
<tr data-category-id={{subcategory.id}} data-notification-level={{subcategory.notificationLevelString}} class="{{if subcategory.description_excerpt 'has-description' 'no-description'}} {{if subcategory.uploaded_logo.url 'has-logo' 'no-logo'}}">
<td class="category" style={{border-color subcategory.color}}>
@ -51,6 +52,7 @@
</td>
</tr>
{{/each}}
</tbody>
</table>
{{else if c.subcategories}}
<div class='subcategories'>

3
app/assets/javascripts/discourse/templates/mobile/components/categories-only.hbs
View File

@ -3,6 +3,7 @@
{{#each categories as |c|}}
<div data-category-id={{c.id}} class='category-list-item category' style={{border-color c.color}}>
<table class='topic-list'>
<tbody>
<tr>
<th class="main-link">
{{category-title-link category=c}}
@ -56,7 +57,7 @@
</td>
</tr>
{{/if}}
</tbody>
</table>
<footer class="clearfix">

2
app/assets/javascripts/discourse/templates/mobile/modal/login.hbs
View File

@ -12,6 +12,7 @@
<form id='login-form' method='post'>
<div id="credentials" class={{credentialsClass}}>
<table>
<tbody>
<tr>
<td>
<label for='login-account-name'>{{i18n 'login.username'}}</label>
@ -34,6 +35,7 @@
<a id="forgot-password-link" {{action "showForgotPassword"}}>{{i18n 'forgot_password.action'}}</a>
</td>
</tr>
</tbody>
</table>
</div>
{{#second-factor-form

4
app/assets/javascripts/discourse/templates/modal/create-account.hbs
View File

@ -11,7 +11,7 @@
<div class="login-form">
<form>
<table>
<tbody>
<tr class="input create-account-email">
<td class="label"><label for='new-account-email'>{{i18n 'user.email.title'}}</label></td>
<td>
@ -95,7 +95,7 @@
accountUsername=accountUsername
accountPassword=accountPassword
userFields=userFields)}}
</tbody>
</table>
{{#if userFields}}

4
app/assets/javascripts/discourse/templates/modal/explain-reviewable.hbs
View File

@ -1,6 +1,7 @@
{{#d-modal-body class="explain-reviewable"}}
{{#conditional-loading-spinner condition=loading}}
<table>
<tbody>
<tr>
<th>{{i18n "review.explain.formula"}}</th>
<th>{{i18n "review.explain.subtotal"}}</th>
@ -21,9 +22,11 @@
<td>{{i18n "review.explain.total"}}</td>
<td class='sum'>{{float reviewableExplanation.total_score}}</td>
</tr>
</tbody>
</table>
<table class='thresholds'>
<tbody>
<tr>
<td>{{i18n "review.explain.min_score_visibility"}}</td>
<td class='sum'>
@ -36,6 +39,7 @@
{{float reviewableExplanation.hide_post_score}}
</td>
</tr>
</tbody>
</table>
{{/conditional-loading-spinner}}

2
app/assets/javascripts/discourse/templates/modal/login.hbs
View File

@ -6,6 +6,7 @@
<form id='login-form' method='post'>
<div id="credentials" class={{credentialsClass}}>
<table>
<tbody>
<tr>
<td><label for='login-account-name'>{{i18n 'login.username'}}</label></td>
<td>{{text-field value=loginName placeholderKey="login.email_placeholder" id="login-account-name" autocorrect="off" autocapitalize="off" autofocus="autofocus" disabled=disableLoginFields}}</td>
@ -20,6 +21,7 @@
<td><div class="caps-lock-warning {{unless capsLockOn 'hidden'}}">{{d-icon "exclamation-triangle"}} {{i18n 'login.caps_lock_warning'}}</div></td>
<td></td>
</tr>
</tbody>
</table>
</div>
{{#second-factor-form

2
app/assets/javascripts/discourse/templates/preferences/account.hbs
View File

@ -104,6 +104,7 @@
<label class="control-label">{{i18n 'user.associated_accounts.title'}}</label>
{{#if associatedAccountsLoaded}}
<table>
<tbody>
{{#each authProviders as |authProvider|}}
{{#if authProvider.account}}
<tr class="{{dasherize authProvider.method.name}} account-connected">
@ -128,6 +129,7 @@
</tr>
{{/if}}
{{/each}}
</tbody>
</table>
{{else}}
<div class="controls">

2
app/assets/javascripts/discourse/templates/user-invited-show.hbs
View File

@ -43,6 +43,7 @@
{{#if model.invites}}
<table class='table user-invite-list'>
<tbody>
<tr>
{{#if inviteRedeemed}}
<th>{{i18n 'user.invited.user'}}</th>
@ -101,6 +102,7 @@
{{/if}}
</tr>
{{/each}}
</tbody>
</table>
{{conditional-loading-spinner condition=invitesLoading}}