From 12a0260a8cc069a786b9731d5572aba8c729d2ef Mon Sep 17 00:00:00 2001 From: Neil Lalonde Date: Thu, 19 Jun 2014 15:18:47 -0400 Subject: [PATCH] FIX: show 404 page for links to categories that don't exists or you don't have access to, instead of showing blank page with js errors --- .../javascripts/discourse/routes/discovery_route_builders.js | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/app/assets/javascripts/discourse/routes/discovery_route_builders.js b/app/assets/javascripts/discourse/routes/discovery_route_builders.js index aa829e31fce..14ec47169a8 100644 --- a/app/assets/javascripts/discourse/routes/discovery_route_builders.js +++ b/app/assets/javascripts/discourse/routes/discovery_route_builders.js @@ -99,6 +99,11 @@ function buildCategoryRoute(filter, params) { }, afterModel: function(model, transaction) { + if (!model) { + this.replaceWith('/404'); + return; + } + var self = this, noSubcategories = params && !!params.no_subcategories, filterMode = "category/" + Discourse.Category.slugFor(model) + (noSubcategories ? "/none" : "") + "/l/" + filter,