github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-01-19 03:43:15 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

FIX: ensures rects is present before using it (#11930)

Browse Source 
I don't have a clear reproduction ATM, but I imagine that in fast tests element can get destroyed before we get to use it.
This commit is contained in:
Joffrey JAFFEUX 2021-02-02 14:43:13 +01:00 committed by GitHub
parent fa33e4863d
commit 12a4fefef6
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 14 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
app/assets/javascripts/select-kit/addon/components/select-kit.js
View File

@ -883,7 +883,10 @@ export default Component.extend(
wrapper.style.height = `${height}px`; wrapper.style.height = `${height}px`;
if (placementStrategy === "fixed") { if (placementStrategy === "fixed") {
const rects = this.element.getClientRects()[0]; const rects = this.element.getClientRects()[0];
if (rects) {
const bodyRects = body && body.getClientRects()[0]; const bodyRects = body && body.getClientRects()[0];
wrapper.style.position = "fixed"; wrapper.style.position = "fixed";
wrapper.style.left = `${rects.left}px`; wrapper.style.left = `${rects.left}px`;
if (topPlacement && bodyRects) { if (topPlacement && bodyRects) {
@ -896,6 +899,7 @@ export default Component.extend(
} }
} }
} }
}
}, },
}, },
], ],