From 133ab03c0165ef64bd0b16a09ca562a2d5116bc7 Mon Sep 17 00:00:00 2001 From: Kyle Zhao Date: Fri, 25 Aug 2017 02:36:58 -0400 Subject: [PATCH] fix 'details' button acceptance test --- .../acceptance/details-button-test.js.es6 | 20 +++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/plugins/discourse-details/test/javascripts/acceptance/details-button-test.js.es6 b/plugins/discourse-details/test/javascripts/acceptance/details-button-test.js.es6 index cbb30b82e64..93ff83cc2ed 100644 --- a/plugins/discourse-details/test/javascripts/acceptance/details-button-test.js.es6 +++ b/plugins/discourse-details/test/javascripts/acceptance/details-button-test.js.es6 @@ -16,7 +16,7 @@ test('details button', (assert) => { andThen(() => { assert.equal( find(".d-editor-input").val(), - `\n[details=${I18n.t("composer.details_title")}]\n${I18n.t("composer.details_text")}\n[/details]\n`, + `\n[details="${I18n.t("composer.details_title")}"]\n${I18n.t("composer.details_text")}\n[/details]\n`, 'it should contain the right output' ); }); @@ -35,13 +35,13 @@ test('details button', (assert) => { andThen(() => { assert.equal( find(".d-editor-input").val(), - `\n[details=${I18n.t("composer.details_title")}]\nThis is my title\n[/details]\n`, + `\n[details="${I18n.t("composer.details_title")}"]\nThis is my title\n[/details]\n`, 'it should contain the right selected output' ); const textarea = findTextarea(); - assert.equal(textarea.selectionStart, 19, 'it should start highlighting at the right position'); - assert.equal(textarea.selectionEnd, 35, 'it should end highlighting at the right position'); + assert.equal(textarea.selectionStart, 21, 'it should start highlighting at the right position'); + assert.equal(textarea.selectionEnd, 37, 'it should end highlighting at the right position'); }); fillIn('.d-editor-input', "Before some text in between After"); @@ -58,13 +58,13 @@ test('details button', (assert) => { andThen(() => { assert.equal( find(".d-editor-input").val(), - `Before \n[details=${I18n.t("composer.details_title")}]\nsome text in between\n[/details]\n After`, + `Before \n[details="${I18n.t("composer.details_title")}"]\nsome text in between\n[/details]\n After`, 'it should contain the right output' ); const textarea = findTextarea(); - assert.equal(textarea.selectionStart, 26, 'it should start highlighting at the right position'); - assert.equal(textarea.selectionEnd, 46, 'it should end highlighting at the right position'); + assert.equal(textarea.selectionStart, 28, 'it should start highlighting at the right position'); + assert.equal(textarea.selectionEnd, 48, 'it should end highlighting at the right position'); }); fillIn('.d-editor-input', "Before \nsome text in between\n After"); @@ -81,12 +81,12 @@ test('details button', (assert) => { andThen(() => { assert.equal( find(".d-editor-input").val(), - `Before \n\n[details=${I18n.t("composer.details_title")}]\nsome text in between\n[/details]\n\n After`, + `Before \n\n[details="${I18n.t("composer.details_title")}"]\nsome text in between\n[/details]\n\n After`, 'it should contain the right output' ); const textarea = findTextarea(); - assert.equal(textarea.selectionStart, 27, 'it should start highlighting at the right position'); - assert.equal(textarea.selectionEnd, 47, 'it should end highlighting at the right position'); + assert.equal(textarea.selectionStart, 29, 'it should start highlighting at the right position'); + assert.equal(textarea.selectionEnd, 49, 'it should end highlighting at the right position'); }); });