github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-01-19 07:02:46 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

DEV: Don't polute all ActiveRecord classes (#15103)

Browse Source 
`pending`, `approved`, `rejected`, `ignored`, and `deleted` scope method were accessible on all model classes… 😂

Fixes `Creating scope :pending. Overwriting existing method DiscoursePostEvent::EventDate.pending.` warnings.
This commit is contained in:
Jarek Radosz 2021-11-26 03:17:10 +01:00 committed by GitHub
parent 73db60ad2a
commit 1441226b1a
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
app/models/reviewable.rb
View File

@ -80,7 +80,7 @@ class Reviewable < ActiveRecord::Base
# Generate `pending?`, `rejected?`, etc helper methods
statuses.each do |name, id|
define_method("#{name}?") { status == id }
self.class.define_method(name) { where(status: id) }
singleton_class.define_method(name) { where(status: id) }
end
def self.default_visible