From 168a38dc2943756ad62c0a240d8c9f726708ea93 Mon Sep 17 00:00:00 2001 From: Arpit Jalan Date: Wed, 26 Jun 2019 23:20:39 +0530 Subject: [PATCH] Bump onebox version. - better Twitch placeholder - CSS for said placeholder --- Gemfile | 2 +- Gemfile.lock | 4 ++-- .../stylesheets/common/base/onebox.scss | 23 +++++++++++++++---- 3 files changed, 21 insertions(+), 8 deletions(-) diff --git a/Gemfile b/Gemfile index f29aaaf28ad..c83cdd937d6 100644 --- a/Gemfile +++ b/Gemfile @@ -46,7 +46,7 @@ gem 'redis-namespace' gem 'active_model_serializers', '~> 0.8.3' -gem 'onebox', '1.8.93' +gem 'onebox', '1.8.94' gem 'http_accept_language', '~>2.0.5', require: false diff --git a/Gemfile.lock b/Gemfile.lock index b70872bf311..5d76ce0c798 100644 --- a/Gemfile.lock +++ b/Gemfile.lock @@ -238,7 +238,7 @@ GEM omniauth-twitter (1.4.0) omniauth-oauth (~> 1.1) rack - onebox (1.8.93) + onebox (1.8.94) htmlentities (~> 4.3) moneta (~> 1.0) multi_json (~> 1.11) @@ -486,7 +486,7 @@ DEPENDENCIES omniauth-oauth2 omniauth-openid omniauth-twitter - onebox (= 1.8.93) + onebox (= 1.8.94) openid-redis-store parallel_tests pg diff --git a/app/assets/stylesheets/common/base/onebox.scss b/app/assets/stylesheets/common/base/onebox.scss index e63a9e979b4..895a522c47b 100644 --- a/app/assets/stylesheets/common/base/onebox.scss +++ b/app/assets/stylesheets/common/base/onebox.scss @@ -583,10 +583,23 @@ aside.onebox.stackexchange .onebox-body { } .onebox-video-placeholder { - &:before { - opacity: 0.8; - content: svg-uri( - '' - ); + position: relative; + width: 100%; + padding: 0 0 56.25% 0; + background-color: $primary-low; + + .video-placeholder-icon { + &:before { + opacity: 0.8; + content: svg-uri( + '' + ); + } + position: absolute; + width: 100%; + height: 100%; + display: flex; + justify-content: center; + align-items: center; } }