DEV: Move problem checks to app directory (#26120)

Browse Source

There are a couple of reasons for this.

The first one is practical, and related to eager loading. Since /lib is not eager loaded, when the application boots, ProblemCheck["identifier"] will be nil because the child classes aren't loaded.

The second one is more conceptual. There turns out to be a lot of inter-dependencies between the part of the problem check system that live in /app and the parts that live in /lib, which probably suggests it should all go in /app.

...

This commit is contained in:

Ted Johansson 2024-03-11 13:36:22 +08:00 committed by GitHub

parent 147e5563fb

commit 2211ffa851

No known key found for this signature in database

GPG Key ID: B5690EEEBB952194

7 changed files with 0 additions and 0 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Show Stats Download Patch File Download Diff File Expand all files Collapse all files

0

lib/problem_check.rb → app/models/problem_check.rb

0

lib/problem_check/group_email_credentials.rb → app/services/problem_check/group_email_credentials.rb

0

lib/problem_check/problem.rb → app/services/problem_check/problem.rb

0

lib/problem_check/twitter_login.rb → app/services/problem_check/twitter_login.rb

0

spec/lib/problem_check_spec.rb → spec/models/problem_check_spec.rb

0

spec/lib/problem_check/group_email_credentials_spec.rb → spec/services/problem_check/group_email_credentials_spec.rb

0

spec/lib/problem_check/twitter_login_spec.rb → spec/services/problem_check/twitter_login_spec.rb