github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-01-19 03:12:46 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

DEV: Add general pretender for passkey challenge (#25432)

Browse Source 
* DEV: Add general pretender for passkey challenge

* Limit a test to Chrome because of Firefox ESR flakiness
This commit is contained in:
Penar Musaraj 2024-01-29 22:13:59 +01:00 committed by GitHub
parent d29fefd73a
commit 2558543794
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
16 changed files with 15 additions and 103 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
app/assets/javascripts/discourse/tests/acceptance/create-account-from-login-test.js
View File

@ -2,13 +2,7 @@ import { click, fillIn, visit } from "@ember/test-helpers";
import { test } from "qunit";
import { acceptance } from "discourse/tests/helpers/qunit-helpers";
acceptance("Create Account Fields - From Login Form", function (needs) {
needs.pretender((server, helper) => {
server.get(`/session/passkey/challenge.json`, () =>
helper.response({ challenge: "smth" })
);
});
acceptance("Create Account Fields - From Login Form", function () {
test("autofills email field with login form value", async function (assert) {
await visit("/");
await click("header .login-button");

8
app/assets/javascripts/discourse/tests/acceptance/forgot-password-test.js
View File

@ -16,10 +16,6 @@ acceptance("Forgot password", function (needs) {
user_found: userFound,
});
});
server.get(`/session/passkey/challenge.json`, () =>
helper.response({ challenge: "smth" })
);
});
test("requesting password reset", async function (assert) {
@ -96,10 +92,6 @@ acceptance(
server.post("/session/forgot_password", () => {
return helper.response({});
});
server.get(`/session/passkey/challenge.json`, () =>
helper.response({ challenge: "smth" })
);
});
test("requesting password reset", async function (assert) {

4
app/assets/javascripts/discourse/tests/acceptance/groups-index-test.js
View File

@ -8,9 +8,7 @@ import {
query,
} from "discourse/tests/helpers/qunit-helpers";
acceptance("Groups", function (needs) {
needs.settings({ enable_passkeys: false });
acceptance("Groups", function () {
test("Browsing Groups", async function (assert) {
await visit("/g?username=eviltrout");
assert.strictEqual(count(".group-box"), 1, "it displays user's groups");

14
app/assets/javascripts/discourse/tests/acceptance/login-redirect-test.js
View File

@ -2,13 +2,7 @@ import { currentRouteName, visit } from "@ember/test-helpers";
import { test } from "qunit";
import { acceptance } from "discourse/tests/helpers/qunit-helpers";
acceptance("Login redirect - anonymous", function (needs) {
needs.pretender((server, helper) => {
server.get(`/session/passkey/challenge.json`, () =>
helper.response({ challenge: "smth" })
);
});
acceptance("Login redirect - anonymous", function () {
test("redirects login to default homepage", async function (assert) {
await visit("/login");
assert.strictEqual(
@ -24,12 +18,6 @@ acceptance("Login redirect - categories default", function (needs) {
top_menu: "categories|latest|top|hot",
});
needs.pretender((server, helper) => {
server.get(`/session/passkey/challenge.json`, () =>
helper.response({ challenge: "smth" })
);
});
test("when site setting is categories", async function (assert) {
await visit("/login");
assert.strictEqual(

6
app/assets/javascripts/discourse/tests/acceptance/login-required-test.js
View File

@ -9,12 +9,6 @@ import {
acceptance("Login Required", function (needs) {
needs.settings({ login_required: true });
needs.pretender((server, helper) => {
server.get(`/session/passkey/challenge.json`, () =>
helper.response({ challenge: "smth" })
);
});
test("redirect", async function (assert) {
await visit("/latest");
assert.strictEqual(

6
app/assets/javascripts/discourse/tests/acceptance/mobile-sign-in-test.js
View File

@ -5,12 +5,6 @@ import { acceptance, exists } from "discourse/tests/helpers/qunit-helpers";
acceptance("Signing In - Mobile", function (needs) {
needs.mobileView();
needs.pretender((server, helper) => {
server.get(`/session/passkey/challenge.json`, () =>
helper.response({ challenge: "smth" })
);
});
test("sign in", async function (assert) {
await visit("/");
await click("header .login-button");

30
app/assets/javascripts/discourse/tests/acceptance/modal/login/login-test.js
View File

@ -1,15 +1,11 @@
import { click, fillIn, tab, visit } from "@ember/test-helpers";
import { test } from "qunit";
import sinon from "sinon";
import { acceptance } from "discourse/tests/helpers/qunit-helpers";
import { acceptance, chromeTest } from "discourse/tests/helpers/qunit-helpers";
import I18n from "discourse-i18n";
acceptance("Modal - Login", function (needs) {
needs.settings({
enable_passkeys: false,
});
test("You can tab to the login button", async function (assert) {
acceptance("Modal - Login", function () {
chromeTest("You can tab to the login button", async function (assert) {
await visit("/");
await click("header .login-button");
// you have to press the tab key twice to get to the login button
@ -33,10 +29,6 @@ acceptance("Modal - Login - With 2FA", function (needs) {
totp_enabled: true,
})
);
server.get(`/session/passkey/challenge.json`, () =>
helper.response({ challenge: "smth" })
);
});
test("You can tab to 2FA login button", async function (assert) {
@ -53,13 +45,7 @@ acceptance("Modal - Login - With 2FA", function (needs) {
});
});
acceptance("Modal - Login - With Passkeys enabled", function (needs) {
needs.pretender((server, helper) => {
server.get(`/session/passkey/challenge.json`, () =>
helper.response({ challenge: "smth" })
);
});
acceptance("Modal - Login - With Passkeys enabled", function () {
test("Includes passkeys button and conditional UI", async function (assert) {
await visit("/");
await click("header .login-button");
@ -89,14 +75,6 @@ acceptance("Modal - Login - With Passkeys disabled", function (needs) {
acceptance("Modal - Login - Passkeys on mobile", function (needs) {
needs.mobileView();
needs.pretender((server, helper) => {
server.get(`/session/passkey/challenge.json`, () =>
helper.response({
challenge: "some-challenge",
})
);
});
test("Includes passkeys button and conditional UI", async function (assert) {
await visit("/");
await click("header .login-button");

1
app/assets/javascripts/discourse/tests/acceptance/modal/login/login-with-email-and-hide-email-address-taken-test.js
View File

@ -7,7 +7,6 @@ acceptance("Login with email - hide email address taken", function (needs) {
needs.settings({
enable_local_logins_via_email: true,
hide_email_address_taken: true,
enable_passkeys: false,
});
needs.pretender((server, helper) => {

3
app/assets/javascripts/discourse/tests/acceptance/modal/login/login-with-email-and-no-social-logins-test.js
View File

@ -10,9 +10,6 @@ acceptance("Login with email - no social logins", function (needs) {
needs.settings({ enable_local_logins_via_email: true });
needs.pretender((server, helper) => {
server.post("/u/email-login", () => helper.response({ success: "OK" }));
server.get(`/session/passkey/challenge.json`, () =>
helper.response({ challenge: "smth" })
);
});
test("with login with email enabled", async function (assert) {
await visit("/");

1
app/assets/javascripts/discourse/tests/acceptance/modal/login/login-with-email-disabled-test.js
View File

@ -6,7 +6,6 @@ acceptance("Login with email disabled", function (needs) {
needs.settings({
enable_local_logins_via_email: false,
enable_facebook_logins: true,
enable_passkeys: false,
});
test("with email button", async function (assert) {

1
app/assets/javascripts/discourse/tests/acceptance/modal/login/login-with-email-test.js
View File

@ -15,7 +15,6 @@ acceptance("Login with email", function (needs) {
needs.settings({
enable_local_logins_via_email: true,
enable_facebook_logins: true,
enable_passkeys: false,
});
let userFound = false;

8
app/assets/javascripts/discourse/tests/acceptance/new-message-test.js
View File

@ -7,13 +7,7 @@ import {
} from "discourse/tests/helpers/qunit-helpers";
import selectKit from "discourse/tests/helpers/select-kit-helper";
acceptance("New Message - Anonymous", function (needs) {
needs.pretender((server, helper) => {
server.get(`/session/passkey/challenge.json`, () =>
helper.response({ challenge: "smth" })
);
});
acceptance("New Message - Anonymous", function () {
test("accessing new-message route when logged out", async function (assert) {
await visit(
"/new-message?username=charlie&title=message%20title&body=message%20body"

8
app/assets/javascripts/discourse/tests/acceptance/new-topic-test.js
View File

@ -3,13 +3,7 @@ import { test } from "qunit";
import { acceptance, exists } from "discourse/tests/helpers/qunit-helpers";
import selectKit from "discourse/tests/helpers/select-kit-helper";
acceptance("New Topic - Anonymous", function (needs) {
needs.pretender((server, helper) => {
server.get(`/session/passkey/challenge.json`, () =>
helper.response({ challenge: "smth" })
);
});
acceptance("New Topic - Anonymous", function () {
test("accessing new-topic route when logged out", async function (assert) {
await visit("/new-topic?title=topic%20title&body=topic%20body");

8
app/assets/javascripts/discourse/tests/acceptance/sign-in-test.js
View File

@ -6,13 +6,7 @@ import {
query,
} from "discourse/tests/helpers/qunit-helpers";
acceptance("Signing In", function (needs) {
needs.pretender((server, helper) => {
server.get(`/session/passkey/challenge.json`, () =>
helper.response({ challenge: "smth" })
);
});
acceptance("Signing In", function () {
test("sign in", async function (assert) {
await visit("/");
await click("header .login-button");

8
app/assets/javascripts/discourse/tests/acceptance/static-test.js
View File

@ -2,13 +2,7 @@ import { currentRouteName, visit } from "@ember/test-helpers";
import { test } from "qunit";
import { acceptance } from "discourse/tests/helpers/qunit-helpers";
acceptance("Static pages", function (needs) {
needs.pretender((server, helper) => {
server.get(`/session/passkey/challenge.json`, () =>
helper.response({ challenge: "smth" })
);
});
acceptance("Static pages", function () {
test("/faq", async function (assert) {
await visit("/faq");
assert.true(

4
app/assets/javascripts/discourse/tests/helpers/create-pretender.js
View File

@ -1298,6 +1298,10 @@ export function applyDefaultHandlers(pretender) {
);
pretender.get("/c/:id/visible_groups.json", () => response({ groups: [] }));
pretender.get("/session/passkey/challenge.json", () =>
response({ challenge: "123" })
);
}
export function resetPretender() {