github-mirror/discourse
github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-03-26 21:26:00 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

DEV: Fix syntax for Link entity header for experimental_preconnect_link_header (#26218)

Browse Source 
Per https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Link, the
syntax for multiple links is something like

```
Link: <https://one.example.com>; rel="preconnect", <https://two.example.com>; rel="preconnect", <https://three.example.com>; rel="preconnect"
```

There should be no trailing `;` before the `,`.
This commit is contained in:
Alan Guo Xiang Tan 2024-03-18 19:49:16 +08:00 committed by GitHub
parent 85bf6c6833
commit 27b0ebff4c
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
app/controllers/application_controller.rb
View File

@ -1108,9 +1108,9 @@ class ApplicationController < ActionController::Base
next if url.blank? next if url.blank?
base_url = URI.join(url, "/").to_s.chomp("/") base_url = URI.join(url, "/").to_s.chomp("/")
links.push("<#{base_url}>; rel=preconnect;") links.push("<#{base_url}>; rel=preconnect")
# Not all browsers support the preconnect resource hint so we are adding dns-prefetch as the fallback # Not all browsers support the preconnect resource hint so we are adding dns-prefetch as the fallback
links.push("<#{base_url}>; rel=dns-prefetch;") links.push("<#{base_url}>; rel=dns-prefetch")
end end
end end

4
spec/requests/application_controller_spec.rb
View File

@ -1200,7 +1200,7 @@ RSpec.describe ApplicationController do
expect(response.status).to eq(200) expect(response.status).to eq(200)
expect(response.headers["Link"]).to include( expect(response.headers["Link"]).to include(
"<https://cdn.example.com>; rel=preconnect;, <https://cdn.example.com>; rel=dns-prefetch;", "<https://cdn.example.com>; rel=preconnect, <https://cdn.example.com>; rel=dns-prefetch",
) )
end end
@ -1212,7 +1212,7 @@ RSpec.describe ApplicationController do
expect(response.status).to eq(200) expect(response.status).to eq(200)
expect(response.headers["Link"]).to include( expect(response.headers["Link"]).to include(
"<https://s3.some-cdn.com>; rel=preconnect;, <https://s3.some-cdn.com>; rel=dns-prefetch;", "<https://s3.some-cdn.com>; rel=preconnect, <https://s3.some-cdn.com>; rel=dns-prefetch",
) )
end end
end end