FEATURE: Enable inline onebox for all domains by default (#11523)

config/site_settings.yml

@@ -1605,7 +1605,7 @@ onebox:
     type: list
     list_type: compact
   enable_inline_onebox_on_all_domains:
-    default: false
+    default: true
   force_custom_user_agent_hosts:
     default: "http://codepen.io"
     type: list

lib/inline_oneboxer.rb

@@ -42,6 +42,9 @@ class InlineOneboxer
             opts[:post_author] = post_author_for_title(topic, post_number)
           end
           return onebox_for(url, topic.title, opts)
+        else
+          # not permitted to see topic
+          return nil
         end
       end
     end

spec/components/inline_oneboxer_spec.rb

@@ -148,6 +148,7 @@ describe InlineOneboxer do
     end
 
     it "will not crawl domains that aren't allowlisted" do
+      SiteSetting.enable_inline_onebox_on_all_domains = false
       onebox = InlineOneboxer.lookup("https://eviltrout.com", skip_cache: true)
       expect(onebox).to be_blank
     end