diff --git a/plugins/chat/spec/system/chat_message_onebox_spec.rb b/plugins/chat/spec/system/chat_message_onebox_spec.rb index f65ba445bbb..1a6c6dace11 100644 --- a/plugins/chat/spec/system/chat_message_onebox_spec.rb +++ b/plugins/chat/spec/system/chat_message_onebox_spec.rb @@ -37,10 +37,7 @@ RSpec.describe "Chat message onebox", type: :system, js: true do it "is oneboxed" do chat_page.visit_channel(channel_1) - channel_page.send_message( - "https://en.wikipedia.org/wiki/Hyperlink", - check_message_presence: false, - ) + channel_page.send_message("https://en.wikipedia.org/wiki/Hyperlink") expect(page).to have_content("This is a test", wait: 20) end diff --git a/plugins/chat/spec/system/edited_message_spec.rb b/plugins/chat/spec/system/edited_message_spec.rb index 8786940bcd6..ca7bd6f30af 100644 --- a/plugins/chat/spec/system/edited_message_spec.rb +++ b/plugins/chat/spec/system/edited_message_spec.rb @@ -39,12 +39,7 @@ RSpec.describe "Edited message", type: :system, js: true do message_1 = Fabricate(:chat_message, chat_channel: channel_1, user: current_user) chat_page.visit_channel(channel_1) - channel_page.edit_message( - message_1, - '[date=2025-03-10 timezone="Europe/Paris"]', - check_message_presence: false, - ) - + channel_page.edit_message(message_1, '[date=2025-03-10 timezone="Europe/Paris"]') expect(page).to have_css(".cooked-date") end end diff --git a/plugins/chat/spec/system/message_errors_spec.rb b/plugins/chat/spec/system/message_errors_spec.rb index 65b72f7fa74..430a7365f85 100644 --- a/plugins/chat/spec/system/message_errors_spec.rb +++ b/plugins/chat/spec/system/message_errors_spec.rb @@ -16,7 +16,7 @@ RSpec.describe "Message errors", type: :system, js: true do sign_in(current_user) chat_page.visit_channel(channel) - channel_page.send_message("atoolongmessage" + "a" * max_length, check_message_presence: false) + channel_page.send_message("atoolongmessage" + "a" * max_length) expect(page).to have_no_content("atoolongmessage") expect(page).to have_content(I18n.t("chat.errors.message_too_long", count: max_length)) diff --git a/plugins/chat/spec/system/page_objects/chat/chat_channel.rb b/plugins/chat/spec/system/page_objects/chat/chat_channel.rb index 030e9d39315..bfeb94507b0 100644 --- a/plugins/chat/spec/system/page_objects/chat/chat_channel.rb +++ b/plugins/chat/spec/system/page_objects/chat/chat_channel.rb @@ -120,19 +120,19 @@ module PageObjects find("[data-value='edit']").click end - def edit_message(message, text = nil, check_message_presence: true) + def edit_message(message, text = nil) open_edit_message(message) - send_message(text, check_message_presence:) if text + send_message(text) if text end - def send_message(text = nil, check_message_presence: true) + def send_message(text = nil) text ||= Faker::Lorem.characters(number: SiteSetting.chat_minimum_message_length) text = text.chomp if text.present? # having \n on the end of the string counts as an Enter keypress composer.fill_in(with: text) click_send_message - expect(messages).to have_message(text: text, persisted: true) if check_message_presence + messages.has_message?(text: text, persisted: true) click_composer - expect(self).to have_no_loading_skeleton + has_no_loading_skeleton? text end diff --git a/plugins/chat/spec/system/page_objects/chat/chat_thread.rb b/plugins/chat/spec/system/page_objects/chat/chat_thread.rb index f883bdd25bc..3187cb98e45 100644 --- a/plugins/chat/spec/system/page_objects/chat/chat_thread.rb +++ b/plugins/chat/spec/system/page_objects/chat/chat_thread.rb @@ -62,7 +62,7 @@ module PageObjects text = text.chomp if text.present? # having \n on the end of the string counts as an Enter keypress composer.fill_in(with: text) click_send_message - expect(messages).to have_message(text: text, persisted: true) + messages.has_message?(text: text, persisted: true) click_composer text end diff --git a/plugins/chat/spec/system/transcript_spec.rb b/plugins/chat/spec/system/transcript_spec.rb index 24e239b3337..aa4fafbd041 100644 --- a/plugins/chat/spec/system/transcript_spec.rb +++ b/plugins/chat/spec/system/transcript_spec.rb @@ -141,7 +141,7 @@ RSpec.describe "Quoting chat message transcripts", type: :system, js: true do clip_text = copy_messages_to_clipboard(message_1) click_selection_button("cancel") - chat_channel_page.send_message(clip_text, check_message_presence: false) + chat_channel_page.send_message(clip_text) expect(page).to have_selector(".chat-message", count: 2) expect(page).to have_css(".chat-transcript")