From 35275c137bf26e0ab736286e250f76a5a7fc2127 Mon Sep 17 00:00:00 2001 From: David Taylor Date: Tue, 5 Mar 2019 12:10:53 +0000 Subject: [PATCH] PERF: Remove final N+1 from theme admin page The rails bug previously mentioned only causes an issue when using `pluck`, so this controller is not affected. Followup to a8ffc02d06a12325f07f7cb7a8ff87119c3d3d0c --- app/controllers/admin/themes_controller.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/controllers/admin/themes_controller.rb b/app/controllers/admin/themes_controller.rb index b491f1699ae..b2d73a399b6 100644 --- a/app/controllers/admin/themes_controller.rb +++ b/app/controllers/admin/themes_controller.rb @@ -107,7 +107,7 @@ class Admin::ThemesController < Admin::AdminController :remote_theme, :theme_settings, :settings_field, - # :locale_fields, # Fails due to https://github.com/rails/rails/issues/34456 + :locale_fields, :user, :color_scheme, theme_fields: :upload