github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-01-18 10:42:45 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

DEV: Remove unused screenNotFull code (#26979)

Browse Source
This commit is contained in:
Jarek Radosz 2024-05-12 20:29:07 +02:00 committed by GitHub
parent fcd2293226
commit 38bd0b3f86
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
3 changed files with 0 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
app/assets/javascripts/discourse/app/mixins/load-more.js
View File

@ -9,12 +9,6 @@ export default Mixin.create(Scrolling, {
return this.eyeline?.update();
},
loadMoreUnlessFull() {
if (this.screenNotFull()) {
this.send("loadMore");
}
},
@on("didInsertElement")
_bindEyeline() {
const eyeline = Eyeline.create({

8
app/assets/javascripts/discourse/app/mixins/scrolling.js
View File

@ -17,12 +17,6 @@ const ScrollingDOMMethods = {
document.removeEventListener("touchmove", onScrollMethod);
window.removeEventListener("scroll", onScrollMethod);
},
screenNotFull() {
return (
window.height > document.querySelector(".ember-application").offsetHeight
);
},
};
const Scrolling = Mixin.create({
@ -59,8 +53,6 @@ const Scrolling = Mixin.create({
ScrollingDOMMethods.bindOnScroll(onScrollMethod);
},
screenNotFull: () => ScrollingDOMMethods.screenNotFull(),
unbindScrolling() {
ScrollingDOMMethods.unbindOnScroll(this._scrollingMixinOnScrollMethod);
},

1
app/assets/javascripts/discourse/tests/setup-tests.js
View File

@ -338,7 +338,6 @@ export default function setupTests(config) {
resetCategoryCache();
sinon.stub(ScrollingDOMMethods, "screenNotFull");
sinon.stub(ScrollingDOMMethods, "bindOnScroll");
sinon.stub(ScrollingDOMMethods, "unbindOnScroll");
});