github-mirror/discourse
github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-03-27 08:12:24 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

DEV: Stop overriding computed property on models/category.js.es6

Browse Source 
This causes an Ember deprecation notice, and is a confusing pattern. We never used the default values, so there is no benefit to including them.
This commit is contained in:
David Taylor 2019-10-14 16:26:48 +01:00
parent 2c011252f1
commit 392f6cdf33
1 changed files with 2 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
app/assets/javascripts/discourse/models/category.js.es6
View File

@ -5,6 +5,8 @@ import { on } from "ember-addons/ember-computed-decorators";
import PermissionType from "discourse/models/permission-type";
const Category = RestModel.extend({
permissions: null,
@on("init")
setupGroupsAndPermissions() {
const availableGroups = this.available_groups;
@ -161,15 +163,6 @@ const Category = RestModel.extend({
this.availableGroups.addObject(permission.group_name);
},
@computed
permissions() {
return Ember.A([
{ group_name: "everyone", permission: PermissionType.create({ id: 1 }) },
{ group_name: "admins", permission: PermissionType.create({ id: 2 }) },
{ group_name: "crap", permission: PermissionType.create({ id: 3 }) }
]);
},
@computed("topics")
latestTopic(topics) {
if (topics && topics.length) {