diff --git a/spec/services/flags/create_flag_spec.rb b/spec/services/flags/create_flag_spec.rb index 4906ecbcefc..ea530943e59 100644 --- a/spec/services/flags/create_flag_spec.rb +++ b/spec/services/flags/create_flag_spec.rb @@ -41,6 +41,8 @@ RSpec.describe(Flags::CreateFlag) do let!(:flag) { Fabricate(:flag, name:) } it { is_expected.to fail_a_policy(:unique_name) } + + after { flag.destroy! } end context "when everything's ok" do @@ -54,6 +56,8 @@ RSpec.describe(Flags::CreateFlag) do ) end + after { flag.destroy! } + it { is_expected.to run_successfully } it "creates the flag" do diff --git a/spec/services/flags/destroy_flag_spec.rb b/spec/services/flags/destroy_flag_spec.rb index 8569cdb3055..cb2e9e3c9bc 100644 --- a/spec/services/flags/destroy_flag_spec.rb +++ b/spec/services/flags/destroy_flag_spec.rb @@ -11,24 +11,28 @@ RSpec.describe(Flags::DestroyFlag) do let(:flag_id) { flag.id } context "when model is not found" do + after { flag.destroy! } let(:flag_id) { 0 } it { is_expected.to fail_to_find_a_model(:flag) } end context "when the flag is a system one" do + after { flag.destroy! } let(:flag) { Flag.first } it { is_expected.to fail_a_policy(:not_system) } end context "when the flag has been used" do + after { flag.destroy! } let!(:post_action) { Fabricate(:post_action, post_action_type_id: flag.id) } it { is_expected.to fail_a_policy(:not_used) } end context "when user is not allowed to perform the action" do + after { flag.destroy! } fab!(:current_user) { Fabricate(:user) } it { is_expected.to fail_a_policy(:invalid_access) } diff --git a/spec/services/flags/reorder_flag_spec.rb b/spec/services/flags/reorder_flag_spec.rb index 540501e0372..2e5c594616d 100644 --- a/spec/services/flags/reorder_flag_spec.rb +++ b/spec/services/flags/reorder_flag_spec.rb @@ -42,6 +42,10 @@ RSpec.describe(Flags::ReorderFlag) do end context "when everything's ok" do + after do + described_class.call(flag_id: flag.id, guardian: current_user.guardian, direction: "down") + end + it { is_expected.to run_successfully } it "moves the flag" do diff --git a/spec/services/flags/toggle_flag_spec.rb b/spec/services/flags/toggle_flag_spec.rb index 3ba43240ba3..871e5a36441 100644 --- a/spec/services/flags/toggle_flag_spec.rb +++ b/spec/services/flags/toggle_flag_spec.rb @@ -34,6 +34,8 @@ RSpec.describe(Flags::ToggleFlag) do end context "when everything's ok" do + after { flag.reload.update!(enabled: true) } + it { is_expected.to run_successfully } it "toggles the flag" do diff --git a/spec/services/flags/update_flag_spec.rb b/spec/services/flags/update_flag_spec.rb index 70b216727c2..b0d240e0ea8 100644 --- a/spec/services/flags/update_flag_spec.rb +++ b/spec/services/flags/update_flag_spec.rb @@ -36,6 +36,8 @@ RSpec.describe(Flags::UpdateFlag) do let(:enabled) { false } let(:auto_action_type) { true } + after { flag.destroy! } + context "when contract is invalid" do let(:name) { nil } @@ -70,6 +72,8 @@ RSpec.describe(Flags::UpdateFlag) do let!(:flag_2) { Fabricate(:flag, name:) } it { is_expected.to fail_a_policy(:unique_name) } + + after { flag_2.destroy! } end context "when everything's ok" do