github-mirror/discourse
github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-03-21 16:06:40 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

FIX: don't break when posting invalid URIs

Browse Source
This commit is contained in:
Régis Hanol 2018-04-19 12:29:35 +02:00
parent 74b812593c
commit 45850a0cd6
2 changed files with 9 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
app/models/topic_link.rb
View File

@ -118,7 +118,7 @@ SQL
.map do |u| .map do |u|
uri = begin uri = begin
URI.parse(u.url) URI.parse(u.url)
rescue URI::InvalidURIError rescue URI::Error
end end
[u, uri] [u, uri]

8
spec/models/topic_link_spec.rb
View File

@ -169,6 +169,14 @@ http://b.com/#{'a' * 500}
end end
end end
context "email address" do
it "does not extract a link" do
post = topic.posts.create(user: user, raw: "Valid email: foo@bar.com\n\nInvalid email: rfc822;name@domain.com")
TopicLink.extract_from(post)
expect(topic.topic_links).to be_blank
end
end
context "mail link" do context "mail link" do
let(:post) { topic.posts.create(user: user, raw: "[email]bar@example.com[/email]") } let(:post) { topic.posts.create(user: user, raw: "[email]bar@example.com[/email]") }