From 482bcc8726a2ac9cfbf39f02b9eb09f056ab2989 Mon Sep 17 00:00:00 2001 From: Joffrey JAFFEUX <j.jaffeux@gmail.com> Date: Wed, 17 Mar 2021 16:03:09 +0100 Subject: [PATCH] A11Y: associates lists with labels on interface page (#12426) --- .../discourse/app/templates/preferences/interface.hbs | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/app/assets/javascripts/discourse/app/templates/preferences/interface.hbs b/app/assets/javascripts/discourse/app/templates/preferences/interface.hbs index 7cba81b8196..4c07cafbdbf 100644 --- a/app/assets/javascripts/discourse/app/templates/preferences/interface.hbs +++ b/app/assets/javascripts/discourse/app/templates/preferences/interface.hbs @@ -77,9 +77,10 @@ {{/if}} <div class="control-group text-size"> - <label class="control-label">{{i18n "user.text_size.title"}}</label> + <label for="text-size-selector" class="control-label">{{i18n "user.text_size.title"}}</label> <div class="controls"> {{combo-box + id="text-size-selector" valueProperty="value" content=textSizes value=textSize @@ -95,9 +96,10 @@ {{#if siteSettings.allow_user_locale}} <div class="control-group pref-locale"> - <label class="control-label">{{i18n "user.locale.title"}}</label> + <label for="locale-selector" class="control-label">{{i18n "user.locale.title"}}</label> <div class="controls"> {{combo-box + id="locale-selector" valueProperty="value" langProperty="value" content=availableLocales @@ -116,9 +118,10 @@ {{/if}} <div class="control-group home"> - <label class="control-label">{{i18n "user.home"}}</label> + <label for="home-selector" class="control-label">{{i18n "user.home"}}</label> <div class="controls"> {{combo-box + id="home-selector" content=userSelectableHome valueProperty="value" value=homepageId @@ -144,7 +147,7 @@ {{/if}} {{preference-checkbox labelKey="user.dynamic_favicon" checked=model.user_option.dynamic_favicon class="pref-dynamic-favicon"}} <div class="controls controls-dropdown pref-page-title"> - <label for="user-email-level">{{i18n "user.title_count_mode.title"}}</label> + <label for="user-title-count-mode">{{i18n "user.title_count_mode.title"}}</label> {{combo-box valueProperty="value" content=titleCountModes