REFACTOR: Import visit helper rather than using a global variable

This commit is contained in:
Robin Ward 2020-10-14 16:10:38 -04:00
parent bb165ac8b1
commit 51d10db7f2
123 changed files with 125 additions and 5 deletions
.eslintrc
app/assets/javascripts
discourse-loader.js
discourse/tests/acceptance
about-test.jsaccount-created-test.jsadmin-emails-test.jsadmin-search-log-term-test.jsadmin-search-logs-test.jsadmin-site-settings-test.jsadmin-site-text-test.jsadmin-suspend-user-test.jsadmin-user-badges-test.jsadmin-user-emails-test.jsadmin-user-index-test.jsadmin-users-list-test.jsadmin-watched-words-test.jsauth-complete-test.jsbadges-test.jsbookmarks-test.jscategory-banner-test.jscategory-chooser-test.jscategory-edit-security-test.jscategory-edit-test.jsclick-track-test.jscomposer-actions-test.jscomposer-attachment-test.jscomposer-edit-conflict-test.jscomposer-hyperlink-test.jscomposer-onebox-test.jscomposer-tags-test.jscomposer-test.jscomposer-topic-links-test.jscomposer-uncategorized-test.jscreate-account-external-test.jscreate-account-user-fields-test.jscustom-html-set-test.jscustom-html-template-test.jsdashboard-test.jsemail-notice-test.jsemoji-picker-test.jsemoji-test.jsencoded-category-test.jsenforce-second-factor-test.jsforgot-password-test.jsgroup-card-mobile-test.jsgroup-card-test.jsgroup-index-test.jsgroup-manage-categories-test.jsgroup-manage-interaction-test.jsgroup-manage-logs-test.jsgroup-manage-membership-test.jsgroup-manage-profile-test.jsgroup-manage-tags-test.jsgroup-requests-test.jsgroup-test.jsgroups-index-test.jsgroups-new-test.jshamburger-menu-test.jshashtags-test.jsinvite-accept-test.jsinvite-show-user-fields-test.jsjump-to-test.jskeyboard-shortcuts-test.jslogin-redirect-test.jslogin-required-test.jslogin-with-email-and-hide-email-address-taken-test.jslogin-with-email-and-no-social-logins-test.jslogin-with-email-disabled-test.jslogin-with-email-test.jsmobile-discovery-test.jsmobile-sign-in-test.jsmobile-users-test.jsmodal-test.jsnew-message-test.jsnew-topic-test.jsnotifications-filter-test.jspage-publishing-test.jspassword-reset-test.jspersonal-message-test.jsplugin-keyboard-shortcut-test.jsplugin-outlet-connector-class-test.jsplugin-outlet-decorator-test.jsplugin-outlet-multi-template-test.jsplugin-outlet-single-template-test.jspost-admin-menu-test.jspreferences-test.jsraw-plugin-outlet-test.jsredirect-to-top-test.jsreports-test.jsreview-test.jssearch-full-test.jssearch-mobile-test.jssearch-test.jsshare-and-invite-desktop-test.jsshare-and-invite-mobile-test.jsshared-drafts-test.jssign-in-test.jsstatic-test.jstag-groups-test.jstags-intersection-test.jstags-test.js

@ -8,6 +8,6 @@
"moduleForComponent": "off",
"testStart": "off",
"testDone": "off",
"sinon": "off"
"sinon": "off",
}
}

@ -146,9 +146,6 @@ var define, requirejs;
"@ember/object/internals": {
guidFor: Ember.guidFor,
},
"@ember/test-helpers": {
setResolver: window.setResolver,
},
I18n: {
// eslint-disable-next-line
default: I18n,

@ -1,5 +1,7 @@
import { visit } from "@ember/test-helpers";
import { test } from "qunit";
import { acceptance } from "discourse/tests/helpers/qunit-helpers";
acceptance("About");
test("viewing", async (assert) => {

@ -1,3 +1,4 @@
import { visit } from "@ember/test-helpers";
import { test } from "qunit";
import { acceptance } from "discourse/tests/helpers/qunit-helpers";
import PreloadStore from "discourse/lib/preload-store";

@ -1,3 +1,4 @@
import { visit } from "@ember/test-helpers";
import { test } from "qunit";
import { acceptance } from "discourse/tests/helpers/qunit-helpers";
import pretender from "discourse/tests/helpers/create-pretender";

@ -1,3 +1,4 @@
import { visit } from "@ember/test-helpers";
import { skip } from "qunit";
import { acceptance } from "discourse/tests/helpers/qunit-helpers";
acceptance("Admin - Search Log Term", { loggedIn: true });

@ -1,3 +1,4 @@
import { visit } from "@ember/test-helpers";
import { skip } from "qunit";
import { acceptance } from "discourse/tests/helpers/qunit-helpers";
acceptance("Admin - Search Logs", { loggedIn: true });

@ -1,3 +1,4 @@
import { visit } from "@ember/test-helpers";
import { test } from "qunit";
import { acceptance } from "discourse/tests/helpers/qunit-helpers";
import siteSettingFixture from "discourse/tests/fixtures/site-settings";

@ -1,3 +1,4 @@
import { visit } from "@ember/test-helpers";
import { test } from "qunit";
import { acceptance } from "discourse/tests/helpers/qunit-helpers";

@ -1,3 +1,4 @@
import { visit } from "@ember/test-helpers";
import { test } from "qunit";
import selectKit from "discourse/tests/helpers/select-kit-helper";
import { acceptance } from "discourse/tests/helpers/qunit-helpers";

@ -1,3 +1,4 @@
import { visit } from "@ember/test-helpers";
import { test } from "qunit";
import { acceptance } from "discourse/tests/helpers/qunit-helpers";

@ -1,3 +1,4 @@
import { visit } from "@ember/test-helpers";
import { test } from "qunit";
import I18n from "I18n";
import { acceptance } from "discourse/tests/helpers/qunit-helpers";

@ -1,3 +1,4 @@
import { visit } from "@ember/test-helpers";
import { test } from "qunit";
import selectKit from "discourse/tests/helpers/select-kit-helper";
import { acceptance } from "discourse/tests/helpers/qunit-helpers";

@ -1,3 +1,4 @@
import { visit } from "@ember/test-helpers";
import { test } from "qunit";
import I18n from "I18n";
import { acceptance } from "discourse/tests/helpers/qunit-helpers";

@ -1,3 +1,4 @@
import { visit } from "@ember/test-helpers";
import { test } from "qunit";
import { acceptance } from "discourse/tests/helpers/qunit-helpers";
acceptance("Admin - Watched Words", { loggedIn: true });

@ -1,3 +1,4 @@
import { visit } from "@ember/test-helpers";
import { test } from "qunit";
import { acceptance } from "discourse/tests/helpers/qunit-helpers";
acceptance("Auth Complete", {

@ -1,3 +1,4 @@
import { visit } from "@ember/test-helpers";
import { test } from "qunit";
import selectKit from "discourse/tests/helpers/select-kit-helper";
import { acceptance } from "discourse/tests/helpers/qunit-helpers";

@ -1,3 +1,4 @@
import { visit } from "@ember/test-helpers";
import { skip } from "qunit";
import { test } from "qunit";
import I18n from "I18n";

@ -1,3 +1,4 @@
import { visit } from "@ember/test-helpers";
import { test } from "qunit";
import { acceptance } from "discourse/tests/helpers/qunit-helpers";
import DiscoveryFixtures from "discourse/tests/fixtures/discovery-fixtures";

@ -1,3 +1,4 @@
import { visit } from "@ember/test-helpers";
import { test } from "qunit";
import selectKit from "discourse/tests/helpers/select-kit-helper";
import { acceptance } from "discourse/tests/helpers/qunit-helpers";

@ -1,3 +1,4 @@
import { visit } from "@ember/test-helpers";
import { test } from "qunit";
import selectKit from "discourse/tests/helpers/select-kit-helper";
import { acceptance } from "discourse/tests/helpers/qunit-helpers";

@ -1,3 +1,4 @@
import { visit } from "@ember/test-helpers";
import { skip } from "qunit";
import { test } from "qunit";
import selectKit from "discourse/tests/helpers/select-kit-helper";

@ -1,3 +1,4 @@
import { visit } from "@ember/test-helpers";
import { test } from "qunit";
import pretender from "discourse/tests/helpers/create-pretender";
import { acceptance } from "discourse/tests/helpers/qunit-helpers";

@ -1,3 +1,4 @@
import { visit } from "@ember/test-helpers";
import { test } from "qunit";
import I18n from "I18n";
import selectKit from "discourse/tests/helpers/select-kit-helper";

@ -1,3 +1,4 @@
import { visit } from "@ember/test-helpers";
import { test } from "qunit";
import { acceptance } from "discourse/tests/helpers/qunit-helpers";

@ -1,3 +1,4 @@
import { visit } from "@ember/test-helpers";
import { test } from "qunit";
import I18n from "I18n";
import { acceptance } from "discourse/tests/helpers/qunit-helpers";

@ -1,3 +1,4 @@
import { visit } from "@ember/test-helpers";
import { test } from "qunit";
import { acceptance } from "discourse/tests/helpers/qunit-helpers";

@ -1,3 +1,4 @@
import { visit } from "@ember/test-helpers";
import { test } from "qunit";
import { acceptance } from "discourse/tests/helpers/qunit-helpers";

@ -1,3 +1,4 @@
import { visit } from "@ember/test-helpers";
import { test } from "qunit";
import Category from "discourse/models/category";
import {

@ -1,3 +1,4 @@
import { visit } from "@ember/test-helpers";
import { skip } from "qunit";
import { test } from "qunit";
import I18n from "I18n";

@ -1,3 +1,4 @@
import { visit } from "@ember/test-helpers";
import { test } from "qunit";
import {
acceptance,

@ -1,3 +1,4 @@
import { visit } from "@ember/test-helpers";
import { test } from "qunit";
import selectKit from "discourse/tests/helpers/select-kit-helper";
import {

@ -1,3 +1,4 @@
import { visit } from "@ember/test-helpers";
import { test } from "qunit";
import { acceptance } from "discourse/tests/helpers/qunit-helpers";

@ -1,3 +1,4 @@
import { visit } from "@ember/test-helpers";
import { test } from "qunit";
import { acceptance } from "discourse/tests/helpers/qunit-helpers";

@ -1,3 +1,4 @@
import { visit } from "@ember/test-helpers";
import { test } from "qunit";
import { acceptance } from "discourse/tests/helpers/qunit-helpers";
import { setCustomHTML } from "discourse/helpers/custom-html";

@ -1,3 +1,4 @@
import { visit } from "@ember/test-helpers";
import { test } from "qunit";
import { acceptance } from "discourse/tests/helpers/qunit-helpers";

@ -1,3 +1,4 @@
import { visit } from "@ember/test-helpers";
import { test } from "qunit";
import selectKit from "discourse/tests/helpers/select-kit-helper";
import { acceptance } from "discourse/tests/helpers/qunit-helpers";

@ -1,3 +1,4 @@
import { visit } from "@ember/test-helpers";
import { test } from "qunit";
import {
acceptance,

@ -1,3 +1,4 @@
import { visit } from "@ember/test-helpers";
import { test } from "qunit";
import { acceptance } from "discourse/tests/helpers/qunit-helpers";

@ -1,3 +1,4 @@
import { visit } from "@ember/test-helpers";
import { test } from "qunit";
import { IMAGE_VERSION as v } from "pretty-text/emoji/version";
import { acceptance } from "discourse/tests/helpers/qunit-helpers";

@ -1,3 +1,4 @@
import { visit } from "@ember/test-helpers";
import { test } from "qunit";
import { acceptance } from "discourse/tests/helpers/qunit-helpers";
import DiscoveryFixtures from "discourse/tests/fixtures/discovery-fixtures";

@ -1,3 +1,4 @@
import { visit } from "@ember/test-helpers";
import { test } from "qunit";
import {
acceptance,

@ -1,3 +1,4 @@
import { visit } from "@ember/test-helpers";
import { test } from "qunit";
import I18n from "I18n";
import { acceptance } from "discourse/tests/helpers/qunit-helpers";

@ -1,3 +1,4 @@
import { visit } from "@ember/test-helpers";
import { skip } from "qunit";
import { acceptance } from "discourse/tests/helpers/qunit-helpers";
import DiscourseURL from "discourse/lib/url";

@ -1,3 +1,4 @@
import { visit } from "@ember/test-helpers";
import { skip } from "qunit";
import { acceptance } from "discourse/tests/helpers/qunit-helpers";
import DiscourseURL from "discourse/lib/url";

@ -1,3 +1,4 @@
import { visit } from "@ember/test-helpers";
import { test } from "qunit";
import I18n from "I18n";
import {

@ -1,3 +1,4 @@
import { visit } from "@ember/test-helpers";
import { test } from "qunit";
import {
acceptance,

@ -1,3 +1,4 @@
import { visit } from "@ember/test-helpers";
import { test } from "qunit";
import {
acceptance,

@ -1,3 +1,4 @@
import { visit } from "@ember/test-helpers";
import { test } from "qunit";
import { acceptance } from "discourse/tests/helpers/qunit-helpers";

@ -1,3 +1,4 @@
import { visit } from "@ember/test-helpers";
import { test } from "qunit";
import {
acceptance,

@ -1,3 +1,4 @@
import { visit } from "@ember/test-helpers";
import { test } from "qunit";
import {
acceptance,

@ -1,3 +1,4 @@
import { visit } from "@ember/test-helpers";
import { test } from "qunit";
import {
acceptance,

@ -1,3 +1,4 @@
import { visit } from "@ember/test-helpers";
import { test } from "qunit";
import { acceptance } from "discourse/tests/helpers/qunit-helpers";
import { parsePostData } from "discourse/tests/helpers/create-pretender";

@ -1,3 +1,4 @@
import { visit } from "@ember/test-helpers";
import { test } from "qunit";
import I18n from "I18n";
import selectKit from "discourse/tests/helpers/select-kit-helper";

@ -1,3 +1,4 @@
import { visit } from "@ember/test-helpers";
import { test } from "qunit";
import { acceptance } from "discourse/tests/helpers/qunit-helpers";

@ -1,3 +1,4 @@
import { visit } from "@ember/test-helpers";
import { test } from "qunit";
import I18n from "I18n";
import { acceptance } from "discourse/tests/helpers/qunit-helpers";

@ -1,3 +1,4 @@
import { visit } from "@ember/test-helpers";
import { test } from "qunit";
import {
acceptance,

@ -1,3 +1,4 @@
import { visit } from "@ember/test-helpers";
import { test } from "qunit";
import { acceptance } from "discourse/tests/helpers/qunit-helpers";

@ -1,3 +1,4 @@
import { visit } from "@ember/test-helpers";
import { test } from "qunit";
import { acceptance } from "discourse/tests/helpers/qunit-helpers";
import PreloadStore from "discourse/lib/preload-store";

@ -1,3 +1,4 @@
import { visit } from "@ember/test-helpers";
import { test } from "qunit";
import { acceptance } from "discourse/tests/helpers/qunit-helpers";
import PreloadStore from "discourse/lib/preload-store";

@ -1,3 +1,4 @@
import { visit } from "@ember/test-helpers";
import { test } from "qunit";
import { acceptance } from "discourse/tests/helpers/qunit-helpers";

@ -1,3 +1,4 @@
import { visit } from "@ember/test-helpers";
import { test } from "qunit";
import { acceptance } from "discourse/tests/helpers/qunit-helpers";
import pretender from "discourse/tests/helpers/create-pretender";

@ -1,3 +1,4 @@
import { visit } from "@ember/test-helpers";
import { test } from "qunit";
import { acceptance } from "discourse/tests/helpers/qunit-helpers";

@ -1,3 +1,4 @@
import { visit } from "@ember/test-helpers";
import { test } from "qunit";
import { acceptance } from "discourse/tests/helpers/qunit-helpers";

@ -1,3 +1,4 @@
import { visit } from "@ember/test-helpers";
import { test } from "qunit";
import I18n from "I18n";
import { acceptance } from "discourse/tests/helpers/qunit-helpers";

@ -1,3 +1,4 @@
import { visit } from "@ember/test-helpers";
import { test } from "qunit";
import { acceptance } from "discourse/tests/helpers/qunit-helpers";

@ -1,3 +1,4 @@
import { visit } from "@ember/test-helpers";
import { test } from "qunit";
import { acceptance } from "discourse/tests/helpers/qunit-helpers";

@ -1,3 +1,4 @@
import { visit } from "@ember/test-helpers";
import { test } from "qunit";
import I18n from "I18n";
import { acceptance } from "discourse/tests/helpers/qunit-helpers";

@ -1,3 +1,4 @@
import { visit } from "@ember/test-helpers";
import { test } from "qunit";
import { acceptance } from "discourse/tests/helpers/qunit-helpers";
acceptance("Topic Discovery - Mobile", { mobileView: true });

@ -1,3 +1,4 @@
import { visit } from "@ember/test-helpers";
import { test } from "qunit";
import { acceptance } from "discourse/tests/helpers/qunit-helpers";

@ -1,3 +1,4 @@
import { visit } from "@ember/test-helpers";
import { test } from "qunit";
import { acceptance } from "discourse/tests/helpers/qunit-helpers";

@ -1,3 +1,4 @@
import { visit } from "@ember/test-helpers";
import { skip } from "qunit";
import { test } from "qunit";
import I18n from "I18n";

@ -1,3 +1,4 @@
import { visit } from "@ember/test-helpers";
import { test } from "qunit";
import { acceptance } from "discourse/tests/helpers/qunit-helpers";

@ -1,3 +1,4 @@
import { visit } from "@ember/test-helpers";
import { test } from "qunit";
import selectKit from "discourse/tests/helpers/select-kit-helper";
import { acceptance } from "discourse/tests/helpers/qunit-helpers";

@ -1,3 +1,4 @@
import { visit } from "@ember/test-helpers";
import { test } from "qunit";
import { acceptance } from "discourse/tests/helpers/qunit-helpers";
import selectKit from "discourse/tests/helpers/select-kit-helper";

@ -1,3 +1,4 @@
import { visit } from "@ember/test-helpers";
import { test } from "qunit";
import { acceptance } from "discourse/tests/helpers/qunit-helpers";

@ -1,3 +1,4 @@
import { visit } from "@ember/test-helpers";
import { test } from "qunit";
import I18n from "I18n";
import { acceptance } from "discourse/tests/helpers/qunit-helpers";

@ -1,3 +1,4 @@
import { visit } from "@ember/test-helpers";
import { test } from "qunit";
import I18n from "I18n";
import { acceptance } from "discourse/tests/helpers/qunit-helpers";

@ -1,3 +1,4 @@
import { visit } from "@ember/test-helpers";
import { test } from "qunit";
import { acceptance } from "discourse/tests/helpers/qunit-helpers";
import { withPluginApi } from "discourse/lib/plugin-api";

@ -1,3 +1,4 @@
import { visit } from "@ember/test-helpers";
import { test } from "qunit";
import { acceptance } from "discourse/tests/helpers/qunit-helpers";
import { extraConnectorClass } from "discourse/lib/plugin-connectors";

@ -1,3 +1,4 @@
import { visit } from "@ember/test-helpers";
import { test } from "qunit";
import { acceptance } from "discourse/tests/helpers/qunit-helpers";
import { withPluginApi } from "discourse/lib/plugin-api";

@ -1,3 +1,4 @@
import { visit } from "@ember/test-helpers";
import { test } from "qunit";
import { acceptance } from "discourse/tests/helpers/qunit-helpers";
import { clearCache } from "discourse/lib/plugin-connectors";

@ -1,3 +1,4 @@
import { visit } from "@ember/test-helpers";
import { test } from "qunit";
import { acceptance } from "discourse/tests/helpers/qunit-helpers";

@ -1,3 +1,4 @@
import { visit } from "@ember/test-helpers";
import { test } from "qunit";
import { acceptance } from "discourse/tests/helpers/qunit-helpers";

@ -1,3 +1,4 @@
import { visit } from "@ember/test-helpers";
import { test } from "qunit";
import I18n from "I18n";
import {

@ -1,3 +1,4 @@
import { visit } from "@ember/test-helpers";
import { test } from "qunit";
import { acceptance } from "discourse/tests/helpers/qunit-helpers";
import compile from "handlebars-compiler";

@ -1,3 +1,4 @@
import { visit } from "@ember/test-helpers";
import { test } from "qunit";
import {
acceptance,

@ -1,3 +1,4 @@
import { visit } from "@ember/test-helpers";
import { test } from "qunit";
import { acceptance } from "discourse/tests/helpers/qunit-helpers";

@ -1,3 +1,4 @@
import { visit } from "@ember/test-helpers";
import { test } from "qunit";
import selectKit from "discourse/tests/helpers/select-kit-helper";
import { acceptance } from "discourse/tests/helpers/qunit-helpers";

@ -1,3 +1,4 @@
import { visit } from "@ember/test-helpers";
import { skip } from "qunit";
import { test } from "qunit";
import selectKit from "discourse/tests/helpers/select-kit-helper";

@ -1,3 +1,4 @@
import { visit } from "@ember/test-helpers";
import { test } from "qunit";
import { acceptance } from "discourse/tests/helpers/qunit-helpers";

@ -1,3 +1,4 @@
import { visit } from "@ember/test-helpers";
import { test } from "qunit";
import selectKit from "discourse/tests/helpers/select-kit-helper";
import { acceptance } from "discourse/tests/helpers/qunit-helpers";

@ -1,3 +1,4 @@
import { visit } from "@ember/test-helpers";
import { test } from "qunit";
import { acceptance } from "discourse/tests/helpers/qunit-helpers";

@ -1,3 +1,4 @@
import { visit } from "@ember/test-helpers";
import { test } from "qunit";
import selectKit from "discourse/tests/helpers/select-kit-helper";
import { acceptance } from "discourse/tests/helpers/qunit-helpers";

@ -1,3 +1,4 @@
import { visit } from "@ember/test-helpers";
import { test } from "qunit";
import selectKit from "discourse/tests/helpers/select-kit-helper";
import { acceptance } from "discourse/tests/helpers/qunit-helpers";

@ -1,3 +1,4 @@
import { visit } from "@ember/test-helpers";
import { skip } from "qunit";
import { test } from "qunit";
import { acceptance } from "discourse/tests/helpers/qunit-helpers";

@ -1,3 +1,4 @@
import { visit } from "@ember/test-helpers";
import { test } from "qunit";
import { acceptance } from "discourse/tests/helpers/qunit-helpers";
acceptance("Static");

@ -1,3 +1,4 @@
import { visit } from "@ember/test-helpers";
import { test } from "qunit";
import selectKit from "discourse/tests/helpers/select-kit-helper";
import { acceptance } from "discourse/tests/helpers/qunit-helpers";

@ -1,3 +1,4 @@
import { visit } from "@ember/test-helpers";
import { test } from "qunit";
import { acceptance } from "discourse/tests/helpers/qunit-helpers";

@ -1,3 +1,4 @@
import { visit } from "@ember/test-helpers";
import { test } from "qunit";
import {
updateCurrentUser,

Some files were not shown because too many files have changed in this diff Show More