From 6aae60a2129c01310903584c38c5297006f21dcb Mon Sep 17 00:00:00 2001
From: Isaac Janzen <50783505+janzenisaac@users.noreply.github.com>
Date: Mon, 25 Nov 2024 16:00:52 -0600
Subject: [PATCH] FIX: `Tooltip` styleguide triggers not rendering options
(#29926)
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Tooltips have different triggers / untriggers by device type (mobile / desktop) and this PR provides the correct options in the styleguide based on device type.
# Before
# After
---
.../discourse/components/sections/molecules/tooltips.js | 9 +++++++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --git a/plugins/styleguide/assets/javascripts/discourse/components/sections/molecules/tooltips.js b/plugins/styleguide/assets/javascripts/discourse/components/sections/molecules/tooltips.js
index e3870768341..49d7ccdbc03 100644
--- a/plugins/styleguide/assets/javascripts/discourse/components/sections/molecules/tooltips.js
+++ b/plugins/styleguide/assets/javascripts/discourse/components/sections/molecules/tooltips.js
@@ -8,10 +8,11 @@ import DummyComponent from "discourse/plugins/styleguide/discourse/components/du
export default class Tooltips extends Component {
@service tooltip;
+ @service site;
@tracked label = "What is this?";
- @tracked triggers = TOOLTIP.options.triggers;
- @tracked untriggers = TOOLTIP.options.untriggers;
+ @tracked triggers = TOOLTIP.options.triggers[this.triggersByDevice];
+ @tracked untriggers = TOOLTIP.options.untriggers[this.triggersByDevice];
@tracked arrow = TOOLTIP.options.arrow;
@tracked inline = TOOLTIP.options.inline;
@tracked interactive = TOOLTIP.options.interactive;
@@ -20,6 +21,10 @@ export default class Tooltips extends Component {
@tracked offset = TOOLTIP.options.offset;
@tracked _content = "Hello World!";
+ get triggersByDevice() {
+ return this.site.mobileView ? "mobile" : "desktop";
+ }
+
get content() {
return this._content;
}