github-mirror/discourse
github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-03-23 06:15:41 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

FIX: Optimize query and avoid bloating memory in Jobs::MigrateUploadScheme.

Browse Source
This commit is contained in:
Guo Xiang Tan 2019-04-09 15:44:53 +08:00
parent df7f37f10a
commit 6d0e8821f8
1 changed files with 18 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
app/jobs/scheduled/migrate_upload_scheme.rb
View File

@ -10,7 +10,10 @@ module Jobs
# clean up failed uploads
Upload.where("created_at < ?", 1.hour.ago)
.where("LENGTH(COALESCE(url, '')) = 0")
.destroy_all
.find_each do |upload|
upload.destroy!
end
# migrate uploads to new scheme
problems = Upload.migrate_to_new_scheme(50)
@ -21,9 +24,21 @@ module Jobs
end
# clean up failed optimized images
OptimizedImage.where("LENGTH(COALESCE(url, '')) = 0").destroy_all
OptimizedImage
.where("LENGTH(COALESCE(url, '')) = 0")
.find_each do |optimized_image|
optimized_image.destroy!
end
# Clean up orphan optimized images
OptimizedImage.where("upload_id NOT IN (SELECT id FROM uploads)").destroy_all
OptimizedImage
.joins("LEFT JOIN uploads ON optimized_images.upload_id = uploads.id")
.where("uploads.id IS NULL")
.find_each do |optimized_image|
optimized_image.destroy!
end
# Clean up optimized images that needs to be regenerated
OptimizedImage.joins(:upload)