github-mirror/discourse
github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-04-15 00:21:42 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

FIX: don't extract links from elided parts

Browse Source
This commit is contained in:
Régis Hanol 2016-03-16 22:35:08 +01:00
parent 8577b7e2cc
commit 7acdbc8448
2 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
lib/pretty_text.rb
View File

@ -328,8 +328,8 @@ module PrettyText
def self.extract_links(html)
links = []
doc = Nokogiri::HTML.fragment(html)
# remove href inside quotes
doc.css("aside.quote a").each { |l| l["href"] = "" }
# remove href inside quotes & elided part
doc.css("aside.quote a, .elided a").each { |l| l["href"] = "" }
# extract all links from the post
doc.css("a").each { |l|

4
spec/components/pretty_text_spec.rb
View File

@ -188,6 +188,10 @@ HTML
expect(PrettyText.extract_links("<aside class='quote'>not a linked quote</aside>\n").to_a).to be_empty
end
it "doesn't extract links from elided parts" do
expect(PrettyText.extract_links("<details class='elided'><a href='http://cnn.com'>cnn</a></details>\n").to_a).to be_empty
end
def extract_urls(text)
PrettyText.extract_links(text).map(&:url).to_a
end