github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-01-18 17:02:45 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

Fix: Safari failing to download backups from email links

Browse Source 
disable service workers on safari

bypass serviceworker network if this is a URL with a token param
This commit is contained in:
Jeff Wong 2018-05-15 14:18:45 -07:00
parent a041a42645
commit 82a95164e9
2 changed files with 6 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
app/assets/javascripts/discourse/initializers/register-service-worker.js.es6
View File

@ -6,9 +6,10 @@ export default {
(location.hostname === "localhost");
const isSupported= isSecured && ('serviceWorker' in navigator);
const isSafari = /^((?!chrome|android).)*safari/i.test(navigator.userAgent);
if (isSupported) {
if (Discourse.ServiceWorkerURL) {
if (Discourse.ServiceWorkerURL && !isSafari) {
navigator.serviceWorker
.register(`${Discourse.BaseUri}/${Discourse.ServiceWorkerURL}`)
.catch(error => {

4
app/assets/javascripts/service-worker.js.erb
View File

@ -65,6 +65,10 @@ self.addEventListener('activate', function(event) {
});
self.addEventListener('fetch', function(event) {
// Bypass service workers if this is a url with a token param
if(/\?.*token/i.test(event.request.url)) {
return;
}
// We only want to call event.respondWith() if this is a navigation request
// for an HTML page.
// request.mode of 'navigate' is unfortunately not supported in Chrome