github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-01-19 02:22:46 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

DEV: Enable some of the skipped Firefox tests (#22800)

Browse Source
This commit is contained in:
Jarek Radosz 2023-07-27 04:56:50 +02:00 committed by GitHub
parent 0369839bd3
commit 83043bd453
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 61 additions and 80 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

30
app/assets/javascripts/discourse/tests/acceptance/topic-test.js
View File

@ -1,6 +1,5 @@
import {
acceptance,
chromeTest,
count,
exists,
publishToMessageBus,
@ -376,9 +375,7 @@ acceptance("Topic featured links", function (needs) {
assert.ok(!exists(".gap"), "it hides gap");
});
chromeTest(
"Quoting a quote keeps the original poster name",
async function (assert) {
test("Quoting a quote keeps the original poster name", async function (assert) {
await visit("/t/internationalization-localization/280");
await selectText("#post_5 blockquote");
await click(".quote-button .insert-quote");
@ -388,12 +385,9 @@ acceptance("Topic featured links", function (needs) {
'quote="codinghorror said, post:3, topic:280"'
)
);
}
);
});
chromeTest(
"Quoting a quote of a different topic keeps the original topic title",
async function (assert) {
test("Quoting a quote of a different topic keeps the original topic title", async function (assert) {
await visit("/t/internationalization-localization/280");
await selectText("#post_9 blockquote");
await click(".quote-button .insert-quote");
@ -403,12 +397,9 @@ acceptance("Topic featured links", function (needs) {
'quote="A new topic with a link to another topic, post:3, topic:62"'
)
);
}
);
});
chromeTest(
"Quoting a quote with the Reply button keeps the original poster name",
async function (assert) {
test("Quoting a quote with the Reply button keeps the original poster name", async function (assert) {
await visit("/t/internationalization-localization/280");
await selectText("#post_5 blockquote");
await click(".reply");
@ -418,13 +409,9 @@ acceptance("Topic featured links", function (needs) {
'quote="codinghorror said, post:3, topic:280"'
)
);
}
);
});
// Using J/K on Firefox clean the text selection, so this won't work there
chromeTest(
"Quoting a quote with replyAsNewTopic keeps the original poster name",
async function (assert) {
test("Quoting a quote with replyAsNewTopic keeps the original poster name", async function (assert) {
await visit("/t/internationalization-localization/280");
await selectText("#post_5 blockquote");
await triggerKeyEvent(document, "keypress", "J");
@ -435,8 +422,7 @@ acceptance("Topic featured links", function (needs) {
'quote="codinghorror said, post:3, topic:280"'
)
);
}
);
});
test("Quoting by selecting text can mark the quote as full", async function (assert) {
await visit("/t/internationalization-localization/280");

3
app/assets/javascripts/discourse/tests/integration/components/d-editor-test.js
View File

@ -2,7 +2,6 @@ import { module, test } from "qunit";
import { setupRenderingTest } from "discourse/tests/helpers/component-test";
import { click, fillIn, render, settled } from "@ember/test-helpers";
import {
chromeTest,
exists,
paste,
query,
@ -71,7 +70,7 @@ module("Integration | Component | d-editor", function (hooks) {
}
function testCase(title, testFunc) {
chromeTest(title, async function (assert) {
test(title, async function (assert) {
this.set("value", "hello world.");
await render(hbs`<DEditor @value={{this.value}} />`);

16
app/assets/javascripts/discourse/tests/integration/components/input-size-test.js
View File

@ -1,7 +1,7 @@
import { module } from "qunit";
import { module, test } from "qunit";
import { setupRenderingTest } from "discourse/tests/helpers/component-test";
import { render } from "@ember/test-helpers";
import { chromeTest, query } from "discourse/tests/helpers/qunit-helpers";
import { query } from "discourse/tests/helpers/qunit-helpers";
import { hbs } from "ember-cli-htmlbars";
module(
@ -9,10 +9,7 @@ module(
function (hooks) {
setupRenderingTest(hooks);
// these tests fail on Firefox 78 in CI, skipping for now
chromeTest(
"icon only button, icon and text button, text only button",
async function (assert) {
test("icon only button, icon and text button, text only button", async function (assert) {
await render(
hbs`<DButton @icon="plus" /> <DButton @icon="plus" @label="topic.create" /> <DButton @label="topic.create" />`
);
@ -27,10 +24,9 @@ module(
query(".btn:nth-child(3)").offsetHeight,
"have equal height"
);
}
);
});
chromeTest("button + text input", async function (assert) {
test("button + text input", async function (assert) {
await render(
hbs`<TextField /> <DButton @icon="plus" @label="topic.create" />`
);
@ -42,7 +38,7 @@ module(
);
});
chromeTest("combo box + input", async function (assert) {
test("combo box + input", async function (assert) {
await render(
hbs`<ComboBox @options={{hash none="category.none"}} /> <TextField />`
);