From 8456252c21e0131b5698fa2c68d2096744c338e2 Mon Sep 17 00:00:00 2001
From: Robin Ward <robin.ward@gmail.com>
Date: Thu, 23 Jul 2020 13:49:43 -0400
Subject: [PATCH] Add deprecation for `Discourse.SiteSettings` in a helper

---
 .../javascripts/discourse/app/lib/settings.js       | 13 ++++++++++++-
 1 file changed, 12 insertions(+), 1 deletion(-)

diff --git a/app/assets/javascripts/discourse/app/lib/settings.js b/app/assets/javascripts/discourse/app/lib/settings.js
index f4f6ae6fa68..2013dec079a 100644
--- a/app/assets/javascripts/discourse/app/lib/settings.js
+++ b/app/assets/javascripts/discourse/app/lib/settings.js
@@ -1,5 +1,16 @@
+import deprecated from "discourse-common/lib/deprecated";
+
 export function prioritizeNameInUx(name, siteSettings) {
-  siteSettings = siteSettings || Discourse.SiteSettings;
+  if (!siteSettings) {
+    deprecated(
+      "You must supply `prioritizeNameInUx` with a `siteSettings` object",
+      {
+        since: "2.6.0",
+        dropFrom: "2.7.0"
+      }
+    );
+    siteSettings = Discourse.SiteSettings;
+  }
 
   return (
     !siteSettings.prioritize_username_in_ux && name && name.trim().length > 0