From 85b6b2550ebafe9d5ec67b533bac17f83c141f78 Mon Sep 17 00:00:00 2001 From: Robin Ward Date: Mon, 6 Oct 2014 16:13:30 -0400 Subject: [PATCH] Revert "Add striped category badges under title" This reverts commit 331e63e3af34db231157df5276c97583d8b309fb. --- app/assets/javascripts/discourse/lib/html.js | 7 +---- .../discourse/templates/header.hbs | 6 ++-- .../stylesheets/desktop/topic-post.scss | 28 ++++++------------- 3 files changed, 13 insertions(+), 28 deletions(-) diff --git a/app/assets/javascripts/discourse/lib/html.js b/app/assets/javascripts/discourse/lib/html.js index da587ff51c1..4ca0e163012 100644 --- a/app/assets/javascripts/discourse/lib/html.js +++ b/app/assets/javascripts/discourse/lib/html.js @@ -92,9 +92,6 @@ Discourse.HTML = { html = "<" + elem + " href=\"" + (opts.link === false ? '' : url) + "\" ", categoryStyle; - // Parent stripe implies onlyStripe - if (opts.onlyStripe) { opts.showParent = true; } - html += "data-drop-close=\"true\" class=\"badge-category" + (restricted ? ' restricted' : '' ) + (opts.onlyStripe ? ' clear-badge' : '') + extraClasses + "\" "; @@ -116,10 +113,8 @@ Discourse.HTML = { html += ">" + name + ""; } - if (opts.onlyStripe || (opts.showParent && category.get('parent_category_id'))) { + if (opts.showParent && category.get('parent_category_id')) { var parent = Discourse.Category.findById(category.get('parent_category_id')); - if (!parent) { parent = category; } - categoryStyle = Discourse.HTML.categoryStyle(opts.onlyStripe ? category : parent) || ''; html = "<" + elem + " class='badge-category-parent" + extraClasses + "' style=\"" + categoryStyle + "\" href=\"" + (opts.link === false ? '' : url) + "\">" + diff --git a/app/assets/javascripts/discourse/templates/header.hbs b/app/assets/javascripts/discourse/templates/header.hbs index 4f2d596307a..d8cf81f9cf9 100644 --- a/app/assets/javascripts/discourse/templates/header.hbs +++ b/app/assets/javascripts/discourse/templates/header.hbs @@ -94,7 +94,7 @@ {{#if showExtraInfo}}
-
+
{{#if showStarButton}} {{/if}} @@ -116,9 +116,9 @@ {{/if}} {{#if topic.category.parentCategory}} - {{bound-category-link topic.category.parentCategory onlyStripe="true"}} + {{bound-category-link topic.category.parentCategory}} {{/if}} - {{bound-category-link topic.category onlyStripe="true"}} + {{bound-category-link topic.category}}
diff --git a/app/assets/stylesheets/desktop/topic-post.scss b/app/assets/stylesheets/desktop/topic-post.scss index 3b5bd9984aa..8d14530ede3 100644 --- a/app/assets/stylesheets/desktop/topic-post.scss +++ b/app/assets/stylesheets/desktop/topic-post.scss @@ -540,17 +540,12 @@ iframe { } } -.extra-info.has-category { - h1 { - line-height: 1.0em; - } -} - .extra-info { h1 { margin: 5px 0 0 0; font-size: 1.6em; line-height: 1.3em; + } a.star { @@ -566,20 +561,15 @@ iframe { margin-top: -2px; } - .badge-wrapper { - margin: 0; - padding: 0; + .badge-category { + border-left: 5px solid; + border-color: #aaa; + font-weight: normal; + text-transform: lowercase; + padding: 0 0 0 5px; + margin: 0 5px 0 1px; + vertical-align: top; - .badge-category { - color: $primary; - padding: 0 0 0 3px; - margin-right: 5px; - } - - .badge-category-parent { - margin: 0; - padding: 0px 1px; - } } .title-wrapper {