github-mirror/discourse
github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-03-15 19:05:48 +08:00
Code Issues Actions1 Packages Projects Releases Wiki Activity

UX: disable "Queue For Review" button if user can't perform action. ()

Browse Source 
Currently, it's returning JS error when trying to click the button when the action is already performed by the same staff user.
This commit is contained in:
Vinoth Kannan 2021-08-07 12:36:56 +05:30 committed by GitHub
parent 3fdb64184b
commit 8c27e69523
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 9 additions and 6 deletions
app/assets/javascripts/discourse/app
controllers
flag.js
templates/modal
flag.hbs

14
app/assets/javascripts/discourse/app/controllers/flag.js

@ -180,6 +180,13 @@ export default Controller.extend(ModalFunctionality, {
},
submitDisabled: not("submitEnabled"),
cantFlagForReview: not("notifyModeratorsFlag"),
@discourseComputed("flagsAvailable")
notifyModeratorsFlag(flagsAvailable) {
const notifyModeratorsID = 7;
return flagsAvailable.find((f) => f.id === notifyModeratorsID);
},
// Staff accounts can "take action"
@discourseComputed("flagTopic", "selected.is_custom_flag")
@ -289,12 +296,7 @@ export default Controller.extend(ModalFunctionality, {
},
flagForReview() {
const notifyModeratorsID = 7;
const notifyModerators = this.flagsAvailable.find(
(f) => f.id === notifyModeratorsID
);
this.set("selected", notifyModerators);
this.set("selected", this.get("notifyModeratorsFlag"));
this.send("createFlag", { queue_for_review: true });
this.set("model.hidden", true);
},

1
app/assets/javascripts/discourse/app/templates/modal/flag.hbs

@ -44,6 +44,7 @@
{{d-button
class="btn-danger"
action=(action "flagForReview")
disabled=cantFlagForReview
icon="exclamation-triangle"
label="flagging.flag_for_review"
}}