github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-01-16 05:32:41 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

FIX: Dashboard report change tooltip was not translated (#30541)

Browse Source 
Use i18n in the JS code instead of concatenating English
strings.

c.f. https://meta.discourse.org/t/titles-on-graphs-in-community-health-dashboard-are-not-localized/302776/8?u=martin
This commit is contained in:
Martin Brennan 2025-01-03 11:20:29 +10:00 committed by GitHub
parent 3260654505
commit 8d5c4ecc33
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 15 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
app/assets/javascripts/admin/addon/models/report.js
View File

@ -407,12 +407,21 @@ export default class Report extends EmberObject {
changeTitle(valAtT1, valAtT2, prevPeriodString) {
const change = this.percentChangeString(valAtT1, valAtT2);
let title = "";
const title = [];
if (change) {
title += `${change} change. `;
title.push(
i18n("admin.dashboard.reports.percent_change_tooltip", {
percent: change,
})
);
}
title += `Was ${number(valAtT1)} ${prevPeriodString}.`;
return title;
title.push(
i18n("admin.dashboard.reports.percent_change_tooltip_previous_value", {
previousValue: number(valAtT1),
previousPeriod: prevPeriodString,
})
);
return title.join(" ");
}
@discourseComputed("yesterdayCount")

2
config/locales/client.en.yml
View File

@ -5217,6 +5217,8 @@ en:
reports:
trend_title: "%{percent} change. Currently %{current}, was %{prev} in previous period."
percent_change_tooltip: "%{percent} change."
percent_change_tooltip_previous_value: "Was %{previousValue} %{previousPeriod}."
today: "Today"
yesterday: "Yesterday"
last_7_days: "Last 7"