github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-01-31 03:09:29 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

FIX: prevent event bubbling when closing modals with escape key (#22928)

Browse Source 
This change prevents event bubbling for the Escape key on all modals. Currently when we close the modal using the Escape key, all other event listeners attached will also be triggered (such as closing the chat drawer if it's open).
This commit is contained in:
David Battersby 2023-08-02 17:15:08 +08:00 committed by GitHub
parent 5ae0220638
commit 906bfdebea
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 1 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
app/assets/javascripts/discourse/app/components/d-modal.js
View File

@ -86,6 +86,7 @@ export default class DModal extends Component {
}
if (event.key === "Escape" && this.dismissable) {
event.stopPropagation();
this.args.closeModal({ initiatedBy: CLOSE_INITIATED_BY_ESC });
}