github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-01-31 04:29:29 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

remove old buggy code see: http://meta.discourse.org/t/quoted-you-emails/2226/3

Browse Source 
notify by display name is silly, display name is not unique in the system
This commit is contained in:
Sam Saffron 2013-02-12 18:49:57 +11:00
parent 99526c33da
commit 925925817f
2 changed files with 1 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
app/models/post_alert_observer.rb
View File

@ -101,7 +101,7 @@ class PostAlertObserver < ActiveRecord::Observer
result = []
post.raw.scan(/\[quote=\"([^,]+),.+\"\]/).uniq.each do |m|
username = m.first.strip.downcase
user = User.where("(LOWER(username_lower) = :username or LOWER(name) = :username) and id != :id", username: username, id: post.user_id).first
user = User.where("username_lower = :username and id != :id", username: username, id: post.user_id).first
result << user if user.present?
end
result

5
spec/models/post_alert_observer_spec.rb
View File

@ -37,11 +37,6 @@ describe PostAlertObserver do
context 'quotes' do
it 'notifies a user by display username' do
lambda {
Fabricate(:post, raw: '[quote="Evil Trout, post:1"]whatup[/quote]')
}.should change(evil_trout.notifications, :count).by(1)
end
it 'notifies a user by username' do
lambda {