github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-01-18 11:42:53 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

FIX: at this point in time component can be destroyed (#19677)

Browse Source 
Especially possible in tests
This commit is contained in:
Joffrey JAFFEUX 2023-01-02 19:17:10 +01:00 committed by GitHub
parent cb2f684a43
commit 96e2d92129
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 8 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
plugins/chat/assets/javascripts/discourse/components/chat-channel-selector-modal-inner.js
View File

@ -131,6 +131,10 @@ export default Component.extend({
@action @action
fetchChannelsFromServer(filter) { fetchChannelsFromServer(filter) {
if (this.isDestroyed || this.isDestroying) {
return;
}
this.setProperties({ this.setProperties({
loading: true, loading: true,
searchIndex: this.searchIndex + 1, searchIndex: this.searchIndex + 1,
@ -165,6 +169,10 @@ export default Component.extend({
@action @action
getInitialChannels() { getInitialChannels() {
if (this.isDestroyed || this.isDestroying) {
return;
}
const channels = this.getChannelsWithFilter(this.filter); const channels = this.getChannelsWithFilter(this.filter);
this.set("channels", channels); this.set("channels", channels);
this.focusFirstChannel(channels); this.focusFirstChannel(channels);