FEATURE: register_custom_field_type, support bool and integer

app/models/concerns/has_custom_fields.rb

@@ -1,6 +1,28 @@
-
 module HasCustomFields
   extend ActiveSupport::Concern
+  module Helpers
+    def self.append_field(target, key, value, types)
+      if target.has_key?(key)
+        target[key] = [target[key]] if !target[key].is_a? Array
+        target[key] << cast_custom_field(key, value, types)
+      else
+        target[key] = cast_custom_field(key, value, types)
+      end
+    end
+
+    CUSTOM_FIELD_TRUE = ['t','true', 'T', 'True', 'TRUE'].freeze unless defined? CUSTOM_FIELD_TRUE
+
+    def self.cast_custom_field(key, value, types)
+      return value unless types && type = types[key]
+
+      case type
+        when :boolean then !!CUSTOM_FIELD_TRUE.include?(value)
+        when :integer then value.to_i
+      else
+        value
+      end
+    end
+  end
 
   included do
     has_many :_custom_fields, dependent: :destroy, :class_name => "#{name}CustomField"
@@ -17,19 +39,21 @@ module HasCustomFields
       return result if whitelisted_fields.blank?
       klass.where(foreign_key => ids, :name => whitelisted_fields).pluck(foreign_key, :name, :value).each do |cf|
         result[cf[0]] ||= {}
-        unload_field(result[cf[0]], cf[1], cf[2])
+        append_custom_field(result[cf[0]], cf[1], cf[2])
       end
       result
     end
 
-    def self.unload_field(target, key, value)
+    def self.append_custom_field(target, key, value)
-      if target.has_key?(key)
+      HasCustomFields::Helpers.append_field(target,key,value,@custom_field_types)
-        target[key] = [target[key]] if !target[key].is_a? Array
-        target[key] << value
-      else
-        target[key] = value
-      end
     end
+
+
+    def self.register_custom_field_type(name, type)
+      @custom_field_types ||= {}
+      @custom_field_types[name] = type
+    end
+
   end
 
   def reload(options = nil)
@@ -38,6 +62,7 @@ module HasCustomFields
     super
   end
 
+
   def custom_fields
     @custom_fields ||= refresh_custom_fields_from_db.dup
   end
@@ -57,7 +82,7 @@ module HasCustomFields
   def refresh_custom_fields_from_db
     target = Hash.new
     _custom_fields.pluck(:name,:value).each do |key, value|
-      self.class.unload_field(target, key, value)
+      self.class.append_custom_field(target, key, value)
     end
     @custom_fields_orig = target
     @custom_fields = @custom_fields_orig.dup

spec/components/concern/has_custom_fields_spec.rb

@@ -129,6 +129,18 @@ describe HasCustomFields do
 
     end
 
+    it "supportes type coersion" do
+      test_item = CustomFieldsTestItem.new
+      CustomFieldsTestItem.register_custom_field_type("bool", :boolean)
+      CustomFieldsTestItem.register_custom_field_type("int", :integer)
+
+      test_item.custom_fields = {"bool" => true, "int" => 1}
+      test_item.save
+      test_item.reload
+
+      test_item.custom_fields.should == {"bool" => true, "int" => 1}
+    end
+
     it "simple modifications don't interfere" do
       test_item = CustomFieldsTestItem.new