mirror of
https://github.com/discourse/discourse.git
synced 2025-01-16 06:22:41 +08:00
FIX: Wizard branding step null logo (#30523)
Followup 3135f472e2
Fixes an issue where the wizard branding step would
error if SiteSetting.logo was null, this did not come
up during testing because in our testing discourse-logo-sketch-small.png
is used for the logo settings.
This commit is contained in:
parent
3135f472e2
commit
9a12eb5c3c
|
@ -31,6 +31,7 @@ export default class Image extends Component {
|
|||
hasUpload() {
|
||||
return (
|
||||
!this.uploading &&
|
||||
this.field.value &&
|
||||
!this.field.value.includes("discourse-logo-sketch-small.png")
|
||||
);
|
||||
}
|
||||
|
|
|
@ -59,6 +59,11 @@ describe "Wizard", type: :system do
|
|||
let(:file_path_1) { file_from_fixtures("logo.png", "images").path }
|
||||
let(:file_path_2) { file_from_fixtures("logo.jpg", "images").path }
|
||||
|
||||
before do
|
||||
SiteSetting.logo = nil
|
||||
SiteSetting.logo_small = nil
|
||||
end
|
||||
|
||||
it "lets user configure logos" do
|
||||
wizard_page.go_to_step("branding")
|
||||
expect(wizard_page).to be_on_step("branding")
|
||||
|
|
Loading…
Reference in New Issue
Block a user