github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-01-31 05:49:30 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

Don't add an empty class to the list elements in the hamburger

Browse Source
This commit is contained in:
Robin Ward 2017-02-13 11:27:30 -05:00
parent 07b9c351a4
commit 9d4405d602
2 changed files with 6 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
app/assets/javascripts/discourse/widgets/menu-panel.js.es6
View File

@ -4,7 +4,11 @@ import { h } from 'virtual-dom';
createWidget('menu-links', { createWidget('menu-links', {
html(attrs) { html(attrs) {
const links = [].concat(attrs.contents()); const links = [].concat(attrs.contents());
const liOpts = { className: attrs.heading ? 'heading' : '' }; const liOpts = {};
if (attrs.heading) {
liOpts.className = 'header';
}
const result = []; const result = [];
result.push(h('ul.menu-links.columned', links.map(l => h('li', liOpts, l)))); result.push(h('ul.menu-links.columned', links.map(l => h('li', liOpts, l))));

1
test/javascripts/widgets/hamburger-menu-test.js.es6
View File

@ -114,6 +114,7 @@ widgetTest('general links', {
anonymous: true, anonymous: true,
test(assert) { test(assert) {
assert.ok(this.$("li[class='']").length === 0);
assert.ok(this.$('.latest-topics-link').length); assert.ok(this.$('.latest-topics-link').length);
assert.ok(!this.$('.new-topics-link').length); assert.ok(!this.$('.new-topics-link').length);
assert.ok(!this.$('.unread-topics-link').length); assert.ok(!this.$('.unread-topics-link').length);