From a385f6c48a4b60b9174ddeaa1452cbfe5e88ae28 Mon Sep 17 00:00:00 2001
From: Vinoth Kannan <vinothkannan@vinkas.com>
Date: Thu, 4 Apr 2019 21:49:44 +0530
Subject: [PATCH] REFACTOR: create custom field even when missing post uploads
 not found

---
 app/jobs/scheduled/ensure_post_uploads_existence.rb | 10 ++++------
 1 file changed, 4 insertions(+), 6 deletions(-)

diff --git a/app/jobs/scheduled/ensure_post_uploads_existence.rb b/app/jobs/scheduled/ensure_post_uploads_existence.rb
index 327bdddb4a8..cc3434aa680 100644
--- a/app/jobs/scheduled/ensure_post_uploads_existence.rb
+++ b/app/jobs/scheduled/ensure_post_uploads_existence.rb
@@ -14,7 +14,7 @@ module Jobs
         .destroy_all
 
       Post
-        .joins("LEFT JOIN post_custom_fields cf ON posts.id = cf.post_id AND cf.name = 'missing_uploads'")
+        .joins("LEFT JOIN post_custom_fields cf ON posts.id = cf.post_id AND cf.name = '#{MISSING_UPLOADS}'")
         .where("(posts.cooked LIKE '%<a %' OR posts.cooked LIKE '%<img %') AND cf.id IS NULL")
         .find_in_batches(batch_size: 100) do |posts|
 
@@ -34,11 +34,9 @@ module Jobs
           end
 
           if missing.present?
-            post.preloaded_custom_fields = nil
-            post.custom_fields[MISSING_UPLOADS] = missing
-            post.save_custom_fields
-          elsif post.custom_fields[MISSING_UPLOADS].present?
-            PostCustomField.find_by(post_id: post.id, name: MISSING_UPLOADS).destroy!
+            missing.each { |src| PostCustomField.create!(post_id: post.id, name: MISSING_UPLOADS, value: src) }
+          else
+            PostCustomField.create!(post_id: post.id, name: MISSING_UPLOADS, value: nil)
           end
         end
       end