SECURITY: Fix XSS on unsubscribed page.

This commit is contained in:
Guo Xiang Tan 2017-10-09 09:04:46 +08:00
parent 6fe604b93e
commit a6f2533d38
2 changed files with 14 additions and 0 deletions

@ -110,6 +110,7 @@ class EmailController < ApplicationController
def unsubscribed
@email = params[:email]
raise Discourse::NotFound if !User.find_by_email(params[:email])
@topic = Topic.find_by(id: params[:topic_id].to_i) if params[:topic_id]
end

@ -0,0 +1,13 @@
require 'rails_helper'
RSpec.describe EmailController do
describe '#unsubscribed' do
describe 'when email is invalid' do
it 'should return the right response' do
get '/email/unsubscribed', params: { email: 'somerandomstring' }
expect(response.status).to eq(404)
end
end
end
end