DEV: Don't use the Ember global (#13535)

app/assets/javascripts/admin/addon/controllers/admin-dashboard-reports.js

@@ -2,8 +2,7 @@ import Controller from "@ember/controller";
 import { INPUT_DELAY } from "discourse-common/config/environment";
 import discourseComputed from "discourse-common/utils/decorators";
 import discourseDebounce from "discourse-common/lib/debounce";
-
+import { get } from "@ember/object";
-const { get } = Ember;
 
 export default Controller.extend({
   filter: null,

app/assets/javascripts/admin/addon/models/email-template.js

@@ -1,6 +1,6 @@
 import RestModel from "discourse/models/rest";
 import { ajax } from "discourse/lib/ajax";
-const { getProperties } = Ember;
+import { getProperties } from "@ember/object";
 
 export default RestModel.extend({
   revert() {

app/assets/javascripts/discourse-loader.js

@@ -34,6 +34,8 @@ var define, requirejs;
         inject: Ember.inject.controller,
       },
       "@ember/debug": {
+        assert: Ember.assert,
+        runInDebug: Ember.runInDebug,
         warn: Ember.warn,
       },
       "@ember/object": {

app/assets/javascripts/discourse/app/components/badge-selector.js

@@ -5,7 +5,7 @@ import discourseComputed, {
 import Component from "@ember/component";
 import I18n from "I18n";
 import { findRawTemplate } from "discourse-common/lib/raw-templates";
-const { makeArray } = Ember;
+import { makeArray } from "discourse-common/lib/helpers";
 
 export default Component.extend({
   @discourseComputed("placeholderKey")

app/assets/javascripts/discourse/app/helpers/route-action.js

@@ -1,13 +1,9 @@
-const {
+import { A } from "@ember/array";
-  A: emberArray,
+import Helper from "@ember/component/helper";
-  Helper,
+import { computed, get } from "@ember/object";
-  assert,
+import { getOwner } from "@ember/application";
-  computed,
+import { run } from "@ember/runloop";
-  get,
+import { assert, runInDebug } from "@ember/debug";
-  getOwner,
-  run,
-  runInDebug,
-} = Ember;
 
 function getCurrentRouteInfos(router) {
   let routerLib = router._routerMicrolib || router.router;
@@ -15,12 +11,12 @@ function getCurrentRouteInfos(router) {
 }
 
 function getRoutes(router) {
-  return emberArray(getCurrentRouteInfos(router)).mapBy("_route").reverse();
+  return A(getCurrentRouteInfos(router)).mapBy("_route").reverse();
 }
 
 function getRouteWithAction(router, actionName) {
   let action;
-  let handler = emberArray(getRoutes(router)).find((route) => {
+  let handler = A(getRoutes(router)).find((route) => {
     let actions = route.actions || route._actions;
     action = actions[actionName];
 

app/assets/javascripts/discourse/app/lib/optional-service.js

@@ -1,8 +1,6 @@
-const {
+import { computed } from "@ember/object";
-  computed,
+import { getOwner } from "@ember/application";
-  getOwner,
+import { dasherize } from "@ember/string";
-  String: { dasherize },
-} = Ember;
 
 export default function (name) {
   return computed(function (defaultName) {

app/assets/javascripts/select-kit/addon/components/multi-select/multi-select-filter.js

@@ -1,6 +1,6 @@
 import I18n from "I18n";
 import SelectKitFilterComponent from "select-kit/components/select-kit/select-kit-filter";
-const { isEmpty } = Ember;
+import { isEmpty } from "@ember/utils";
 import discourseComputed from "discourse-common/utils/decorators";
 import layout from "select-kit/templates/components/select-kit/select-kit-filter";
 

plugins/discourse-local-dates/assets/javascripts/lib/date-with-zone-helper.js.es6

@@ -1,4 +1,4 @@
-const { getProperties } = Ember;
+import { getProperties } from "@ember/object";
 
 /*
   DateWithZoneHelper provides a limited list of helpers