From ae369b1100ee9ac140e34a7a4c514c9ee29ceaa6 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Lo=C3=AFc=20Guitaut?= <loic@discourse.org>
Date: Tue, 9 May 2023 11:10:12 +0200
Subject: [PATCH] FIX: Change the limit on badges description
The current limit (250 characters) is too low, as we have some
translations used for our badge descriptions that result in a
description length of 264 characters.
To be on the safe side, the limit is now set to 500 characters.
---
app/models/badge.rb | 2 +-
spec/models/badge_spec.rb | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/app/models/badge.rb b/app/models/badge.rb
index d9601a76585..6f97eeb1a9f 100644
--- a/app/models/badge.rb
+++ b/app/models/badge.rb
@@ -119,7 +119,7 @@ class Badge < ActiveRecord::Base
validates :badge_type, presence: true
validates :allow_title, inclusion: [true, false]
validates :multiple_grant, inclusion: [true, false]
- validates :description, length: { maximum: 250 }
+ validates :description, length: { maximum: 500 }
validates :long_description, length: { maximum: 1000 }
scope :enabled, -> { where(enabled: true) }
diff --git a/spec/models/badge_spec.rb b/spec/models/badge_spec.rb
index a7e49b5ff25..1c59531a8d9 100644
--- a/spec/models/badge_spec.rb
+++ b/spec/models/badge_spec.rb
@@ -5,7 +5,7 @@ RSpec.describe Badge do
subject(:badge) { Fabricate.build(:badge) }
it { is_expected.to validate_length_of(:name).is_at_most(100) }
- it { is_expected.to validate_length_of(:description).is_at_most(250) }
+ it { is_expected.to validate_length_of(:description).is_at_most(500) }
it { is_expected.to validate_length_of(:long_description).is_at_most(1000) }
it { is_expected.to validate_presence_of(:name) }
it { is_expected.to validate_presence_of(:badge_type) }