github-mirror/discourse
github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-04-03 05:39:41 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

FIX: limit visible revisions history to last 100 (#12946)

Browse Source 
This is done to prevent spike memory usage when the number of revisions is very large (thousands) and the post has a significant length.
This commit is contained in:
Joffrey JAFFEUX 2021-05-05 12:18:25 +02:00 committed by GitHub
parent 8f82243ee7
commit b0e9c6e127
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 7 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
app/serializers/post_revision_serializer.rb
View File

@ -190,7 +190,12 @@ class PostRevisionSerializer < ApplicationSerializer
def all_revisions def all_revisions
return @all_revisions if @all_revisions return @all_revisions if @all_revisions
post_revisions = PostRevision.where(post_id: object.post_id).order(:number).to_a post_revisions = PostRevision
.where(post_id: object.post_id)
.order(number: :desc)
.limit(99)
.to_a
.reverse
latest_modifications = { latest_modifications = {
"raw" => [post.raw], "raw" => [post.raw],

2
config/locales/client.en.yml
View File

@ -3374,7 +3374,7 @@ en:
one: "user" one: "user"
other: "users" other: "users"
category_title: "Category" category_title: "Category"
history: "History" history: "History, last 100 revisions"
changed_by: "by %{author}" changed_by: "by %{author}"
raw_email: raw_email: