From b215aac31786d98aeae16cc6f9ef7632d25e2433 Mon Sep 17 00:00:00 2001 From: Krzysztof Kotlarek Date: Tue, 20 Feb 2024 09:08:46 +1100 Subject: [PATCH] DEV: remove unused isInAnyGroups function (#25741) Recently we changed the code to check permission in the backend. Example PR https://github.com/discourse/discourse/pull/25735 After those changes, `isInAnyGroups` and `userInAnyGroups` functions are not used anymore. --- .../javascripts/discourse/app/models/user.js | 14 -------------- .../discourse/app/services/site-settings.js | 5 ----- 2 files changed, 19 deletions(-) diff --git a/app/assets/javascripts/discourse/app/models/user.js b/app/assets/javascripts/discourse/app/models/user.js index eeecc2e6eaf..11721e59bbd 100644 --- a/app/assets/javascripts/discourse/app/models/user.js +++ b/app/assets/javascripts/discourse/app/models/user.js @@ -702,20 +702,6 @@ export default class User extends RestModel.extend(Evented) { return groups.length === 0 ? null : groups; } - // NOTE: This only includes groups *visible* to the user via the serializer, - // so be wary when using this. - isInAnyGroups(groupIds) { - if (!this.groups) { - return; - } - - // auto group ID 0 is "everyone" - return ( - groupIds.includes(0) || - this.groups.mapBy("id").some((groupId) => groupIds.includes(groupId)) - ); - } - // The user's stat count, excluding PMs. @discourseComputed("statsExcludingPms.@each.count") statsCountNonPM() { diff --git a/app/assets/javascripts/discourse/app/services/site-settings.js b/app/assets/javascripts/discourse/app/services/site-settings.js index 91d638307f1..8ed8112238f 100644 --- a/app/assets/javascripts/discourse/app/services/site-settings.js +++ b/app/assets/javascripts/discourse/app/services/site-settings.js @@ -18,11 +18,6 @@ export function createSiteSettingsFromPreloaded(data) { .map((groupId) => parseInt(groupId, 10)); }; - settings.userInAnyGroups = (groupSetting, user) => { - const groupIds = settings.groupSettingArray(groupSetting); - return user.isInAnyGroups(groupIds); - }; - return settings; }