From b3caa90f6e5dd1e5d08e03b33094be437dd963b8 Mon Sep 17 00:00:00 2001 From: Jarek Radosz Date: Mon, 23 Oct 2023 23:14:17 +0200 Subject: [PATCH] DEV: Check for mobile upload button presence (#24059) If rendering would break before `_bindMobileUploadButton` - this would fail too, obscuring the original issue. --- .../discourse/app/mixins/composer-upload-uppy.js | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/app/assets/javascripts/discourse/app/mixins/composer-upload-uppy.js b/app/assets/javascripts/discourse/app/mixins/composer-upload-uppy.js index b9e7e5176a7..0a8438b6c5b 100644 --- a/app/assets/javascripts/discourse/app/mixins/composer-upload-uppy.js +++ b/app/assets/javascripts/discourse/app/mixins/composer-upload-uppy.js @@ -634,21 +634,23 @@ export default Mixin.create(ExtendableUploader, UppyS3Multipart, { this.mobileUploadButton = document.getElementById( this.mobileFileUploaderId ); - this.mobileUploadButtonEventListener = () => { - document.getElementById(this.fileUploadElementId).click(); - }; - this.mobileUploadButton.addEventListener( + this.mobileUploadButton?.addEventListener( "click", - this.mobileUploadButtonEventListener, + this._mobileUploadButtonEventListener, false ); } }, + @bind + _mobileUploadButtonEventListener() { + document.getElementById(this.fileUploadElementId).click(); + }, + _unbindMobileUploadButton() { this.mobileUploadButton?.removeEventListener( "click", - this.mobileUploadButtonEventListener + this._mobileUploadButtonEventListener ); },