github-mirror/discourse
github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-03-22 10:25:35 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

FIX: Replace %20 with space in markdown file name for uploads (#8405)

Browse Source 
Meta: https://meta.discourse.org/t/image-name-has-20-in-file-name/134136

We were ending up with [file%20name](url) in the markdown preview, which looked weird and
affected the alt text. this is because we were calling encodeURIComponent, which has been left in place because this is a valid thing to do for some cases. (e.g. f674b9e)
This commit is contained in:
Martin Brennan 2019-11-25 13:54:55 +10:00 committed by GitHub
parent afb5533581
commit b89e634dd4
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
app/assets/javascripts/discourse/lib/uploads.js.es6
View File

@ -14,7 +14,7 @@ function imageNameFromFileName(fileName) {
name = I18n.t("upload_selector.default_image_alt_text");
}
return encodeURIComponent(name);
return encodeURIComponent(name).replace(/%20/g, " ");
}
export function validateUploadedFiles(files, opts) {

4
test/javascripts/lib/uploads-test.js.es6
View File

@ -200,6 +200,10 @@ QUnit.test("getUploadMarkdown", assert => {
testUploadMarkdown("[foo|bar].png"),
"![%5Bfoo%7Cbar%5D|100x200](/uploads/123/abcdef.ext)"
);
assert.equal(
testUploadMarkdown("file name with space.png"),
"![file name with space|100x200](/uploads/123/abcdef.ext)"
);
const short_url = "uploads://asdaasd.ext";