From b9f553d45d9bcd8e24dee68a7e226f20db335254 Mon Sep 17 00:00:00 2001 From: Vinoth Kannan <vinoth.kannan@discourse.org> Date: Mon, 18 Dec 2017 13:38:47 +0530 Subject: [PATCH] REFACTOR: Small improvement in code for Tag.slice method --- .../javascripts/discourse/lib/to-markdown.js.es6 | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/app/assets/javascripts/discourse/lib/to-markdown.js.es6 b/app/assets/javascripts/discourse/lib/to-markdown.js.es6 index c52b3befbe1..6a5d000c58a 100644 --- a/app/assets/javascripts/discourse/lib/to-markdown.js.es6 +++ b/app/assets/javascripts/discourse/lib/to-markdown.js.es6 @@ -155,10 +155,10 @@ class Tag { }; } - static slice(name, prefix, suffix) { + static slice(name, suffix) { return class extends Tag { constructor() { - super(name, prefix, suffix); + super(name, "", suffix); } decorate(text) { @@ -171,11 +171,11 @@ class Tag { } static cell(name) { - return Tag.slice(name, "", " "); + return Tag.slice(name, " "); } static li() { - return class extends Tag.slice("li", "", "\n") { + return class extends Tag.slice("li", "\n") { decorate(text) { const indent = this.element.filterParentNames("ul").slice(1).map(() => " ").join(""); return super.decorate(`${indent}* ${trimLeft(text)}`); @@ -188,7 +188,7 @@ class Tag { const tags = [ ...Tag.blocks().map((b) => Tag.block(b)), ...Tag.headings().map((h, i) => Tag.heading(h, i + 1)), - ...Tag.slices().map((s) => Tag.slice(s, "", "\n")), + ...Tag.slices().map((s) => Tag.slice(s, "\n")), ...Tag.emphases().map((e) => Tag.emphasis(e[0], e[1])), Tag.cell("td"), Tag.cell("th"), Tag.replace("br", "\n"), Tag.replace("hr", "\n---\n"), Tag.replace("head", ""),