From bcc34420bbfade6e81cc9b84bb51719045ac9bd1 Mon Sep 17 00:00:00 2001 From: Martin Brennan Date: Tue, 7 Jan 2025 10:06:10 +1000 Subject: [PATCH] UX: Remove version from "What's new?" items (#30596) This version number is a technical detail that controls what items show up on certain sites, most admins don't need this level of detail. Remove it here, maybe we can add it back in some hidden way later if needed. --- .../admin/addon/components/dashboard-new-feature-item.gjs | 5 ----- spec/system/admin_dashboard_new_features_spec.rb | 2 -- spec/system/page_objects/pages/admin_new_features.rb | 5 ----- 3 files changed, 12 deletions(-) diff --git a/app/assets/javascripts/admin/addon/components/dashboard-new-feature-item.gjs b/app/assets/javascripts/admin/addon/components/dashboard-new-feature-item.gjs index dd3f94eb17e..bc934f03383 100644 --- a/app/assets/javascripts/admin/addon/components/dashboard-new-feature-item.gjs +++ b/app/assets/javascripts/admin/addon/components/dashboard-new-feature-item.gjs @@ -85,11 +85,6 @@ export default class DiscourseNewFeatureItem extends Component { {{/if}} - {{#if @item.discourse_version}} -
- {{@item.discourse_version}} -
- {{/if}}
diff --git a/spec/system/admin_dashboard_new_features_spec.rb b/spec/system/admin_dashboard_new_features_spec.rb index 533e30b858d..553c60e6cef 100644 --- a/spec/system/admin_dashboard_new_features_spec.rb +++ b/spec/system/admin_dashboard_new_features_spec.rb @@ -56,7 +56,6 @@ describe "Admin New Features Page", type: :system do expect(new_features_page).to have_learn_more_link expect(new_features_page).to have_no_emoji expect(new_features_page).to have_date("November 2023") - expect(new_features_page).to have_version("3.3.0.beta4") end within find(".admin-config-area-card:last-child") do @@ -64,7 +63,6 @@ describe "Admin New Features Page", type: :system do expect(new_features_page).to have_learn_more_link expect(new_features_page).to have_no_emoji expect(new_features_page).to have_date("August 2023") - expect(new_features_page).to have_version("3.3.0.beta3") end end diff --git a/spec/system/page_objects/pages/admin_new_features.rb b/spec/system/page_objects/pages/admin_new_features.rb index 14c52d7686f..1aefd4ee428 100644 --- a/spec/system/page_objects/pages/admin_new_features.rb +++ b/spec/system/page_objects/pages/admin_new_features.rb @@ -32,11 +32,6 @@ module PageObjects page.has_no_css?(".admin-new-feature-item__new-feature-emoji") end - def has_version?(version) - element = find(".admin-new-feature-item__new-feature-version") - element.has_text?(version) - end - def has_date?(date) element = find(".admin-config-area-card__title") element.has_text?(date)