github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-01-01 16:23:45 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

DEV: correctly applies identifier do DModal used in DMenu (#30370)

Browse Source 
A previous refactor used an incorrect path. This commit also adds a simple test to ensure this identifier is present.
This commit is contained in:
Joffrey JAFFEUX 2024-12-19 12:05:39 +01:00 committed by GitHub
parent 0a9ebbe1dd
commit bce0018163
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
app/assets/javascripts/discourse/tests/integration/components/float-kit/d-menu-test.js
View File

@ -47,11 +47,11 @@ module("Integration | Component | FloatKit | d-menu", function (hooks) {
this.site.mobileView = true;
await render(
hbs`<DMenu @inline={{true}} @modalForMobile={{true}} @content="content" />`
hbs`<DMenu @identifier="foo" @inline={{true}} @modalForMobile={{true}} @content="content" />`
);
await open();
assert.dom(".fk-d-menu-modal").hasText("content");
assert.dom(".fk-d-menu-modal[data-identifier='foo']").hasText("content");
});
test("@onRegisterApi", async function (assert) {

2
app/assets/javascripts/float-kit/addon/components/d-menu.gjs
View File

@ -119,7 +119,7 @@ export default class DMenu extends Component {
@class
}}
@inline={{(isTesting)}}
data-identifier={{@instance.options.identifier}}
data-identifier={{this.options.identifier}}
data-content
>
<div class="fk-d-menu-modal__grip" aria-hidden="true"></div>