github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-01-19 03:12:46 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

FIX: filterQueryParams mutates state that is essentially global

Browse Source 
Let's prevent it from doing this by duplicating the input first.
This commit is contained in:
Daniel Waterworth 2019-11-05 11:24:52 +00:00
parent 8e419a772f
commit c008443f2d
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
app/assets/javascripts/discourse/routes/build-topic-route.js.es6
View File

@ -4,7 +4,8 @@ import { defaultHomepage } from "discourse/lib/utilities";
// A helper to build a topic route for a filter // A helper to build a topic route for a filter
function filterQueryParams(params, defaultParams) { function filterQueryParams(params, defaultParams) {
const findOpts = defaultParams || {}; const findOpts = Object.assign({}, defaultParams || {});
if (params) { if (params) {
Object.keys(queryParams).forEach(function(opt) { Object.keys(queryParams).forEach(function(opt) {
if (params[opt]) { if (params[opt]) {