github-mirror/discourse
github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-04-01 22:56:32 +08:00
Code Issues Actions1 Packages Projects Releases Wiki Activity

DEV: refactor calls to message.cook when sending messages ()

Browse Source 
When editing a message, we call `message.cook()` in the beginning of 
`#sendEditMessage` methods, but when sending a new message, 
the call to `message.cook()` is hidden in the `stageMessage` method.

We can just call `message.cook()` before sending the message, no matter 
whether this is a new message or an edited message.
This commit is contained in:
Andrei Prigorshnev 2023-06-08 18:21:22 +04:00 committed by GitHub
parent 9cbbcdef50
commit c0d3cded73
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
4 changed files with 2 additions and 4 deletions
plugins/chat/assets/javascripts/discourse
components
chat-channel.jschat-thread.js
models
chat-channel.jschat-thread.js

2
plugins/chat/assets/javascripts/discourse/components/chat-channel.js

@ -647,6 +647,7 @@ export default class ChatLivePane extends Component {
@action
async onSendMessage(message) {
await message.cook();
if (message.editing) {
await this.#sendEditMessage(message);
} else {
@ -660,7 +661,6 @@ export default class ChatLivePane extends Component {
}
async #sendEditMessage(message) {
await message.cook();
this.pane.sending = true;
const data = {

2
plugins/chat/assets/javascripts/discourse/components/chat-thread.js

@ -228,6 +228,7 @@ export default class ChatThreadPanel extends Component {
async onSendMessage(message) {
resetIdle();
await message.cook();
if (message.editing) {
await this.#sendEditMessage(message);
} else {
@ -281,7 +282,6 @@ export default class ChatThreadPanel extends Component {
}
async #sendEditMessage(message) {
await message.cook();
this.chatThreadPane.sending = true;
const data = {

1
plugins/chat/assets/javascripts/discourse/models/chat-channel.js

@ -292,7 +292,6 @@ export default class ChatChannel {
message.draft = false;
message.createdAt ??= moment.utc().format();
message.channel = this;
await message.cook();
if (message.inReplyTo) {
if (!this.threadingEnabled) {

1
plugins/chat/assets/javascripts/discourse/models/chat-thread.js

@ -69,7 +69,6 @@ export default class ChatThread {
message.draft = false;
message.createdAt ??= moment.utc().format();
message.thread = this;
await message.cook();
this.messagesManager.addMessages([message]);
}